When calculating Kustomize dependencies, include components #6534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling "kustomize(<directory>)" in a Tiltfile, the directory is watched as well as any paths the Kustomization includes. This doesn't currently include components, so Kustomizations that include components[1] don't trigger a reload of the Tiltfile and the Kustomization when files in those components change. This commit adds the "components:"" field of a Kustomization to the list of paths "dependenciesForKustomization" will inspect. [1]: https://github.com/kubernetes-sigs/kustomize/blob/master/examples/components.md Signed-off-by: Sam Clements <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
kustomize(<directory>)in a Tiltfile, the directory is watched as well as any paths the Kustomization includes. This doesn't currently include components, so Kustomizations that include components don't trigger a reload of the Tiltfile and the Kustomization when files in those components change.This PR adds the
components:field of a Kustomization to the list of pathsdependenciesForKustomizationwill inspect.