Skip to content

Fix powershell install crashing when $script:ErrorActionPreference='Stop' and Scoop not installed #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicks merged 1 commit into from
Jan 28, 2025
Merged

Fix powershell install crashing when $script:ErrorActionPreference='Stop' and Scoop not installed #6491

nicks merged 1 commit into from
Jan 28, 2025

Conversation

@asrichesson
Copy link
Contributor

@asrichesson asrichesson commented Jan 28, 2025

While trying to automate installing tilt, I came across this issue. (I don't have scoop installed)

$script:ErrorActionPreference = 'Stop'
iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/tilt-dev/tilt/master/scripts/install.ps1'))

throws the error

Line |
  14 |  if (Get-Command "scoop" 2>$null) {
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The term 'scoop' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

This change prevents the scoop check from throwing an error while also allowing me to stop the installation if it throws a real error.

nicks
nicks approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@nicks nicks merged commit 1482d27 into tilt-dev:master Jan 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicks nicks nicks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asrichesson @nicks