Recognize Red Hat CodeReady Containers as a local cluster #3242
Conversation
There was a problem hiding this comment.
Thanks so much for the issue + fix @noseka1!
Can you add a test for this case in https://github.com/windmilleng/tilt/blob/f154c9cb792f42b8f91e581326518ce7fc20739f/internal/k8s/env_test.go ? Then I think this is ready to merge in
|
Thanks for the link to the unit test file, @jazzdan Test cases for CRC added. |
|
Thanks @noseka1! |
|
Thanks for merging @jazzdan! |
|
Thanks for the contribution @noseka1 . This is now available in the latest release: https://docs.tilt.dev/upgrade.html. And here's the release notes mentioning your contribution: https://github.com/windmilleng/tilt/releases/tag/v0.13.4 |
3 participants
Hi there,
I tried to use tilt in combination with a CodeReady Containers (CRC) cluster. CRC is a slimmed down OpenShift cluster meant to be used for local development, see also Red Hat CodeReady Containers
Based on my testing, tilt works very weill with CRC. I encountered only one trivial glitch: tilt didn't recognize CRC as a local cluster. This pull request fixes it.
Thanks,
Ales