Upgrade [email protected]#79
Conversation
|
@krisselden can you review this? |
krisselden
left a comment
krisselden
left a comment
There was a problem hiding this comment.
Need more explanation to how this is fixes #78 where @asakusuma mentioned that matchFiles changed, I expected some change related to that.
|
Can we merge this so we can get up to date? |
|
It seems like TS thinks we're using private APIs? |
|
We need to, it is too cumbersome to match the globbing behavior in the host interfaces without using that API, so that is not going to change. |
|
I've asked them to make it public or easier. It should be as easy to make a virtual fs like they use in their test suite with public api. |
|
linking some related issues microsoft/TypeScript#13793 There is no reasonable way to deal with include/exclude globing in readDirectory in a host that is trying to gate all fs access without this API. Broccoli treats input as immutable and actually builds inside of tmp directories, the only way to get node resolution and types to work is to pretend in the host like these tmp dirs are "mounted" in the project path. In order to avoid using this API, I would have to parse the glob and match the under-specified glob behavior of matchFiles. |
Since the underlying realpath implementation performs an existence check, there's no need to guard for ENOENT errors, and we can let exceptions propagate as they will represent a more serious error.
tomdale
dismissed
krisselden’s stale review
Synced with Kris via chat, he is okay with merging given the passing test suite (and also tested against glimmer-vm) to unblock the upgrade
5 participants
Fix's #78