Skip to content

Conversation

@BusyJay
Copy link
Member

@BusyJay BusyJay commented Jul 14, 2024

No description provided.

Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
cc = "^1.0.13"

[features]
default = ["stats", "background_threads_runtime_support"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering we are releasing a new minor version, "stats" is removed from the default features to make it easier to control features.

/cc @girlbossceo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any strong reason blocking us from just increasing the patch version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now jemalloc-sys will disable jemalloc stats explicitly if stats feature is not enabled. This may break crates that rely on jemalloc stats but not enable it explicitly. To avoid breaking compatibility (though it's a bug), stats feature was added to the default feature set. But it still breaks those crates that disable the default features. It's more clear to upgrade to a new minor version and ask everyone relies on stats feature to enable it explicitly.

@BusyJay BusyJay requested review from overvenus and sticnarf July 14, 2024 11:05
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@BusyJay BusyJay merged commit f260a80 into main Jul 14, 2024
@BusyJay BusyJay deleted the bump-0.6.0 branch July 14, 2024 15:34
@BusyJay BusyJay mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants