Merged
Conversation
Signed-off-by: Felix Yan <[email protected]>
BusyJay
reviewed
Sep 10, 2021
| println!("cargo:rustc-link-lib=pthread"); | ||
| } | ||
| if target.contains("riscv") { | ||
| println!("cargo:rustc-link-lib=atomic"); |
|
Any idea why you need |
Author
|
I got a lot of linking errors like this, without |
|
OK, I believe this is a GCC deficiency riscvarchive/riscv-gcc#12 #include <stdatomic.h>
char meow(char *ptr, char val) {
return __atomic_exchange_n(ptr, val, memory_order_seq_cst);
}GCC may generate a % riscv64-linux-gnu-gcc -march=rv64gc -O2 -S a.c -o - | grep __atomic
tail __atomic_exchange_1@pltClang doesn't do this. Mix-and-match for a given object size/alignment is not good but it should be fine. libatomic's implementation doesn't use mutex array. |
Member
|
Thank you @MaskRay @felixonmars for the analyze. @felixonmars can you also add the issue link in the code as a comment to explain why atomic is linked against explicitly? |
Author
|
Sure. Hopefully I did it right :) |
Member
|
You need to sign off all your commits, otherwise we can't merge your pr. |
BusyJay
approved these changes
Sep 15, 2021
Signed-off-by: Felix Yan <[email protected]>
Author
Oops. Fixed now. |
|
@MaskRay mix-and-match is not okay according to https://gcc.gnu.org/wiki/Atomic/GCCMM/LIbrary . In this case, the behavior difference of GCC and Clang should be considered as a bug, and as (from my view) LLVM respects GCC for libatomic, Clang should be fixed to invoke atomic*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds fine and all tests are green.