Skip to content

bench: utilize async_(server|client)_threads#67

Merged
siddontang merged 2 commits intomasterfrom
ov/bench
Jul 6, 2017
Merged

bench: utilize async_(server|client)_threads#67
siddontang merged 2 commits intomasterfrom
ov/bench

Conversation

@overvenus
Copy link
Copy Markdown
Member

No description provided.

@overvenus overvenus requested review from BusyJay and siddontang July 6, 2017 03:20
impl Client {
pub fn new(cfg: &ClientConfig) -> Client {
let env = Arc::new(EnvBuilder::new().build());
let mut env = EnvBuilder::new();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a builder not an env.

@BusyJay
Copy link
Copy Markdown
Member

BusyJay commented Jul 6, 2017

LGTM

Copy link
Copy Markdown
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang siddontang merged commit 0d3b2db into master Jul 6, 2017
@siddontang siddontang deleted the ov/bench branch July 6, 2017 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants