CryptoPkg: Increase ScratchMemory buffer for openssl 3.0.15#6394
Merged
mergify[bot] merged 1 commit intotianocore:masterfrom Nov 4, 2024
Merged
CryptoPkg: Increase ScratchMemory buffer for openssl 3.0.15#6394mergify[bot] merged 1 commit intotianocore:masterfrom
mergify[bot] merged 1 commit intotianocore:masterfrom
Conversation
github-actions
Bot
added
the
impact:security
jyao1
added
push
Contributor
|
LGTM. wait for 24 hours to see if there is other concern. |
jyao1
approved these changes
Nov 4, 2024
Openssl 3.0.15 has a larger memory footprint. Updating from EDK 2022.2 (openssl 1.1.j) to 2024.2 (openssl 3.0.15) causes our EFI provisioning application[1] to fail due to an out of memory condition. On inspection, at the time of that fault, 2022.2 had an additional 900 pages. This is why this patch proposes the increase of the ScratchMemory buffer by that same ammount. [1] https://git.kernel.org/pub/scm/linux/kernel/git/jejb/efitools.git Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
mdkinney
force-pushed
the
efitools-oom
branch
from
b74be5a to
feea74b
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Openssl 3.0.15 has a larger memory footprint.
Updating from EDK 2022.2 (openssl 1.1.j) to 2024.2 (openssl 3.0.15) causes our EFI provisioning application[1] to fail due to an out of memory condition.
On inspection, at the time of that fault, 2022.2 had an additional 900 pages. This is why this patch proposes the increase of the ScratchMemory buffer by that same ammount.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/jejb/efitools.git
How This Was Tested
https://git.kernel.org/pub/scm/linux/kernel/git/jejb/efitools.git
0) Build efitools and generate LockDown.efi
Execute LockDown.efi from a systemd-boot menu
Without the fix, authenticating the proposed PK before attempting to set it will fail with a Security Violation error (-26)
Integration Instructions
N/A