MdeModulePkg: fix check for NVM command set in NVMe drivers#2637
Closed
LittleFox94 wants to merge 2 commits intotianocore:masterfrom
Closed
MdeModulePkg: fix check for NVM command set in NVMe drivers#2637LittleFox94 wants to merge 2 commits intotianocore:masterfrom
LittleFox94 wants to merge 2 commits intotianocore:masterfrom
Conversation
LittleFox94
force-pushed
the
nvme-fix-cap-css-check
branch
4 times, most recently
from
370bbef to
5cae05f
Compare
LittleFox94
changed the title
Fix the check for NVMe command set being supported by the controller. Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1 in that register, making the OVMF think the NVMe controller does not support NVMe. Uncovered by commit 9dd14fc, which changed the number of bits included in the Css register from 4 to 8. Signed-off-by: Mara Sophie Grosch <[email protected]>
Previous commit fixed that check in DXE, this one now for PEI. Signed-off-by: Mara Sophie Grosch <[email protected]>
LittleFox94
force-pushed
the
nvme-fix-cap-css-check
branch
from
372688a to
badc89c
Compare
Author
|
Merged via #2682 |
ricardosalveti
added a commit
to ricardosalveti/meta-lmp
that referenced
this pull request
Oct 28, 2022
Backport patches already applied in main and latest edk2 stable in order to fix NVME usage with recent QEMU versions, as described at tianocore/edk2#2637. Signed-off-by: Ricardo Salveti <[email protected]>
ricardosalveti
added a commit
to foundriesio/meta-lmp
that referenced
this pull request
Oct 28, 2022
Backport patches already applied in main and latest edk2 stable in order to fix NVME usage with recent QEMU versions, as described at tianocore/edk2#2637. Signed-off-by: Ricardo Salveti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the check for NVMe command set being supported by the controller.
Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1
in that register, making the OVMF think the NVMe controller does not
support NVMe.
Uncovered by commit 9dd14fc, which
changed the number of bits included in the Css register from 4 to 8.
Signed-off-by: Mara Sophie Grosch [email protected]