Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix recomposition issues in the KernelSU manager by updating dependencies, improving initialization logic, and removing unnecessary remember() calls that were causing excessive recompositions.
Changes:
- Updated several Compose and UI library versions to address recomposition bugs
- Added
isInitializedstate tracking to prevent unnecessary re-initialization of app and module lists on recomposition - Removed unnecessary
remember()wrappers around color derivations that were already stable - Improved search bar UX by clearing search text immediately when collapsing
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| manager/gradle/libs.versions.toml | Updated compose-bom, activity-compose, navigation3, navigationevent, miuix, and capsule to newer versions; removed workaround comment for miuix-navigation3-ui |
| manager/app/src/main/java/me/weishu/kernelsu/ui/viewmodel/ModuleViewModel.kt | Simplified fetchModuleList() by removing conditional logic and direct syncModuleUpdateInfo() call |
| manager/app/src/main/java/me/weishu/kernelsu/ui/util/module/Shortcut.kt | Added explicit import for WebUIActivity instead of using fully qualified name |
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/SuperUser.kt | Added isInitialized tracking and removed unnecessary remember() calls for color values and tags list |
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Module.kt | Added isInitialized tracking, removed LaunchedEffect(modules) block, moved listState declaration, and made parameter naming explicit |
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/AppProfile.kt | Reformatted derivedStateOf and removed unnecessary parentheses from enum class declaration |
| manager/app/src/main/java/me/weishu/kernelsu/ui/component/SuperSearchBar.kt | Added immediate search text clearing when collapsing search for better UX |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Module.kt
Outdated
Show resolved
Hide resolved
manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Module.kt
Outdated
Show resolved
Hide resolved
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Feb 4, 2026
PhuScam
pushed a commit
to PhuScam/KernelSU
that referenced
this pull request
Feb 5, 2026
PhuScam
pushed a commit
to PhuScam/KernelSU
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.