manager: Add confirmation dialog for ZIP module installation via external sources#2989
Merged
tiann merged 1 commit intotiann:mainfrom Nov 25, 2025
Merged
manager: Add confirmation dialog for ZIP module installation via external sources#2989tiann merged 1 commit intotiann:mainfrom
tiann merged 1 commit intotiann:mainfrom
Conversation
refactor intent handling into a dedicated composable
sakana164
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a confirmation dialog to prevent accidental module installation when ZIP files are opened with KernelSU from external file managers, and refactors the intent handling logic into a dedicated composable for better code organization.
- Extracted ZIP file intent handling from the main composition into a new
ZipFileIntentHandlercomposable function - Added a confirmation dialog that displays the module filename before proceeding with installation
- Maintained the same intent state management pattern to handle new intents properly
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
tiann
approved these changes
Nov 25, 2025
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Nov 26, 2025
…rnal sources (tiann#2989) refactor intent handling into a dedicated composable Show a confirmation dialog when users open ZIP files with KernelSU from file managers to prevent accidental installation. Signed-off-by: sakana164 <[email protected]>
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Nov 27, 2025
…rnal sources (tiann#2989) refactor intent handling into a dedicated composable Show a confirmation dialog when users open ZIP files with KernelSU from file managers to prevent accidental installation. Signed-off-by: sakana164 <[email protected]> Signed-off-by: fc5b87cf <[email protected]>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 4, 2026
…rnal sources (tiann#2989) refactor intent handling into a dedicated composable Show a confirmation dialog when users open ZIP files with KernelSU from file managers to prevent accidental installation. Co-authored-by: sakana164 <[email protected]> Signed-off-by: u9521 <[email protected]>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
…rnal sources (tiann#2989) refactor intent handling into a dedicated composable Show a confirmation dialog when users open ZIP files with KernelSU from file managers to prevent accidental installation. Co-authored-by: sakana164 <[email protected]> Signed-off-by: u9521 <[email protected]>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
…rnal sources (tiann#2989) refactor intent handling into a dedicated composable Show a confirmation dialog when users open ZIP files with KernelSU from file managers to prevent accidental installation. Co-authored-by: sakana164 <[email protected]> Signed-off-by: u9521 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor intent handling into a dedicated composable
Show a confirmation dialog when users open ZIP files with KernelSU from file managers to prevent accidental installation.
Signed-off-by: sakana164 [email protected]