Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a module configuration system to KernelSU, migrating the managed features mechanism from module.prop to a dedicated binary config storage format. The new system provides persistent and temporary configuration capabilities for modules, with command-line tools for management.
- Introduces binary config file format with persist/temp support for per-module configuration storage
- Migrates managed features from module.prop declarations to config system entries (manage.=true)
- Adds CLI commands for modules to manage their own configuration via
KSU_MODULEenvironment variable - Implements feature management authorization based on module ownership
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| userspace/ksud/src/module_config.rs | New module implementing binary config file I/O, validation, and config management APIs |
| userspace/ksud/src/module.rs | Updates module loading to extract KSU_MODULE env var, read managed features from config, and clear configs on uninstall |
| userspace/ksud/src/main.rs | Registers the new module_config module |
| userspace/ksud/src/init_event.rs | Adds temp config cleanup during post-fs-data initialization |
| userspace/ksud/src/feature.rs | Updates feature system to check module ownership via config system and skip managed features during init |
| userspace/ksud/src/defs.rs | Defines config directory paths and file name constants |
| userspace/ksud/src/cli.rs | Adds module config subcommands (get, set, list, delete, clear) with persist/temp options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tiann
approved these changes
Nov 20, 2025
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Nov 20, 2025
Co-authored-by: YuKongA <[email protected]>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 4, 2026
Co-authored-by: YuKongA <[email protected]> Signed-off-by: u9521 <[email protected]>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
Co-authored-by: YuKongA <[email protected]> Signed-off-by: u9521 <[email protected]>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
Co-authored-by: YuKongA <[email protected]> Signed-off-by: u9521 <[email protected]>
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Feb 23, 2026
Co-authored-by: YuKongA <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.