✨ Search for variants by folder name if no variants by file name found#38
Merged
tiangolo merged 3 commits intotiangolo:mainfrom Nov 28, 2025
Merged
✨ Search for variants by folder name if no variants by file name found#38tiangolo merged 3 commits intotiangolo:mainfrom
tiangolo merged 3 commits intotiangolo:mainfrom
Conversation
tiangolo
approved these changes
Nov 28, 2025
Owner
tiangolo
left a comment
There was a problem hiding this comment.
Excellent! Impeccable job! 🙌 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to handle situations when we have versions in different folders (version code is in folder name, not in file name).
In case there is no version found for file in current folder, it will attempt to find versions by folders.
In the example above, for
{* docs_src/settings/app02_an/main.py *}it will find:This implementation only handles variants in parent directory of the file. We may want to support several levels.
For example:
The example above is not currently supported (variants will not be found).
One drawback of this implementation is that if we have several versions of one app, but one of files is the same in all versions, this file will still be displayed with versions (all of them will be equal).
To overcome both of issues explained above we can add a config option to specify the level of folder where to search for variants.
For example, to search for variants in
app02**folders:Or, to disable searching for variants in folders (if we don't want to show variants when all of them are equal):