Merged
Conversation
numpy scalars have an 'astype' method, but that method doesn't have a 'casting' kwarg, so we have to handle this case ourselves. Previously we wouldn't have handled raw Python scalars at all. Fixes #121.
python/thunder/rdds/data.py
Outdated
Member
There was a problem hiding this comment.
Discussed offline with @industrial-sloth , we're going to simplify this by dropping the additional hasattr check, and just call return asarray([v], dtype=dtype_)[0] in all cases, which will always convert to the appropriate type and return a valid singleton numpy object.
Member
|
Thanks @industrial-sloth , LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for numpy and python scalars as values of Data records in
Data.astype(). Fixes #121.