Skip to content

Remove password length limit#766

Closed
micahmo wants to merge 2 commits intothunder-app:developfrom
micahmo:fix/password-length-limit
Closed

Remove password length limit#766
micahmo wants to merge 2 commits intothunder-app:developfrom
micahmo:fix/password-length-limit

Conversation

@micahmo
Copy link
Member

@micahmo micahmo commented Sep 25, 2023

Pull Request Description

Removes the limit for password length when logging in.

Issue Being Fixed

Issue Number: https://programming.dev/post/3448277

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

Hmm, there's some caveats when it comes to removing the password limit, especially with password managers.

When filling in the password using a password manager for a password greater than 60 characters, it throws an error. When this happens, it just throws a password_incorrect error which is pretty generic. This can cause confusion with users and they may think there's an issue on Thunder which prevents them from logging in.

For more context, this is the given issue that was opened a while ago for this specific issue: #52 (comment)

If we go forward with this route, we need to think of ways to handle this situation better so that this issue doesn't pop up again!

@micahmo micahmo marked this pull request as draft September 26, 2023 19:36
@micahmo
Copy link
Member Author

micahmo commented Sep 26, 2023

I commented on Lemmy, and I'm hoping we can hear back from snowe about the questions I asked. 😊 For now, I'll leave this as a draft.

@micahmo
Copy link
Member Author

micahmo commented Oct 26, 2023

Since we never heard back from snowe and we have a suspicion that his login would have worked fine due to the known truncation behavior, I'm going to close this PR. I've leave the branch around just in case (although it would be easy enough to recreate if needed).

@micahmo micahmo closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants