Repository navigation
test_summary: count pytest xfailed/xpassed so expected-fail runs are observed - #41
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest summary lines can name expected failures and unexpected passes:
parse_pytest_summary_lineonly countedpassed/failed/error(s)/skipped. Anxfailed/xpassedtoken was ignored, so a run whose only outcomes were expected failures returnedNone— andObservationBuilderthen recorded notest_resultsfor that worker output. The factory looked like the worker never ran tests.A mixed line undercounted too:
1 passed, 2 xfailedbecamepassed=1, total=1instead of three known outcomes.Change: treat
xfailedandxpassedlikeskipped(known non-failing outcomes on the summary line). Warnings and deselected counts stay ignored. Docstring updated.Tests: two cases in
test_parse_pytest_summary_line_exact_outcomes. Both fail onmainand pass with this change.