Merged
Conversation
Some changes in our dependency tree have led to broken builds. For example, `concurrent-ruby`, which Rails uses, stopped requiring `logger` on version 1.3.5, which was fixed in Rails 7.1. Another change is that Ruby decreased its standard library, removing some preloaded gems, such as `mutex_m`. This commit updates the dependencies to the latest supported version, limits the `concurrent-ruby` version to `< 1.3.4` in Rails versions that don't require `logger`, and adds `mutex_m` to the list of development dependencies.
neilvcarvalho
force-pushed
the
nc-fix-build
branch
from
f22abb8 to
7352027
Compare
seanpdoyle
approved these changes
Jan 31, 2025
Contributor
seanpdoyle
left a comment
seanpdoyle
left a comment
There was a problem hiding this comment.
Nice! Will this also fix the Logger-related CI failures? I'd tried to fix them in eae4dbc, but was unsuccessful.
DoodlingDev
approved these changes
Jan 31, 2025
DoodlingDev
reviewed
Jan 31, 2025
| end | ||
|
|
||
| Rails.logger = Logger.new("/dev/null") | ||
| Rails.logger = Logger.new(File::NULL) |
Member
There was a problem hiding this comment.
nice, didn't know about this :scribbles in notes:
Member
Author
There was a problem hiding this comment.
TIL too - thanks new standard check
Member
Author
|
@seanpdoyle It will! That was happening because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes in our dependency tree have led to broken builds. For example,
concurrent-ruby, which Rails uses, stopped requiringloggeron version 1.3.5, which was fixed in Rails 7.1. Another change is that Ruby decreased its standard library, removing some preloaded gems, such asmutex_m.This commit updates the dependencies to the latest supported version, limits the
concurrent-rubyversion to< 1.3.4in Rails versions that don't requirelogger, and addsmutex_mto the list of development dependencies.