railsrc: Skip tests when building new application#744
Merged
stevepolitodesign merged 1 commit intomainfrom May 2, 2024
Merged
Conversation
Follow-up to #728 In an effort to create parity with the [upcoming release of Suspenders][1], we pass the `--skip-test` argument when running [rails new][2]. This means if you're using our `railsrc` file, you would just need to pass the `-m` argument when generating a new Rails application. [1]: thoughtbot/suspenders#1135 [2]: https://guides.rubyonrails.org/command_line.html#rails-new
Contributor
Author
|
As a follow-up, I wonder if we could add the |
mike-burns
approved these changes
Apr 30, 2024
Contributor
mike-burns
left a comment
mike-burns
left a comment
There was a problem hiding this comment.
OK I have now read a bunch of rails/rails issues and some StackOverflow and have decided: LGTM.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #728
In an effort to create parity with the upcoming release of
Suspenders, we pass the
--skip-testargument when running railsnew.
This means if you're using our
railsrcfile, you would just need topass the
-margument when generating a new Rails application.