Skip to content

include production deployment manifest file#712

Merged
sesheta merged 1 commit intothoth-station:masterfrom
harshad16:cnv-prod
Dec 8, 2020
Merged

include production deployment manifest file#712
sesheta merged 1 commit intothoth-station:masterfrom
harshad16:cnv-prod

Conversation

@harshad16
Copy link
Member

Related Issues and Dependencies

Related-To: #709

PROD Environment

  • Pull Requests added content to PROD environment

This Pull Request implements

include production deployment manifest file
Signed-off-by: Harshad Reddy Nalla [email protected]

Description

we would like to maintain a separate overlay for easy addition and deletion of manifests, without interrupting the other deployments.

@harshad16 harshad16 requested a review from goern as a code owner December 8, 2020 18:19
@sesheta sesheta requested a review from pacospace December 8, 2020 18:19
@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 8, 2020
@harshad16
Copy link
Member Author

Merging this manually, won't disrupt any of the existing application environments.
/approve

@sesheta
Copy link
Member

sesheta commented Dec 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@sesheta sesheta merged commit 174dec1 into thoth-station:master Dec 8, 2020
@harshad16 harshad16 deleted the cnv-prod branch January 4, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants