Skip to content

feat: Allow disabling the automatic html report upload to upload-artifacts@v7#6447

Merged
thomhurst merged 1 commit into
thomhurst:mainfrom
Crashdummyy:main
Jul 19, 2026
Merged

feat: Allow disabling the automatic html report upload to upload-artifacts@v7#6447
thomhurst merged 1 commit into
thomhurst:mainfrom
Crashdummyy:main

Conversation

@Crashdummyy

@Crashdummyy Crashdummyy commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds the environment variable TUNIT_DISABLE_ARTIFACT_UPLOAD to control whether the html report is uploaded to the artifacts endpoint

Related Issue

none

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Performance improvement
  • Refactoring (no functional changes)

Checklist

Required

  • I have read the Contributing Guidelines
  • If this is a new feature, I started a discussion first and received agreement
  • My code follows the project's code style (modern C# syntax, proper naming conventions)
  • I have written tests that prove my fix is effective or my feature works

TUnit-Specific Requirements

  • Dual-Mode Implementation: If this change affects test discovery/execution, I have implemented it in BOTH:
    • Source Generator path (TUnit.Core.SourceGenerator)
    • Reflection path (TUnit.Engine)
  • Snapshot Tests: If I changed source generator output or public APIs:
    • I ran TUnit.Core.SourceGenerator.Tests and/or TUnit.PublicAPI tests
    • I reviewed the .received.txt files and accepted them as .verified.txt
    • I committed the updated .verified.txt files
  • Performance: If this change affects hot paths (test discovery, execution, assertions):
    • I minimized allocations and avoided LINQ in hot paths
    • I cached reflection results where appropriate
  • AOT Compatibility: If this change uses reflection:
    • I added appropriate [DynamicallyAccessedMembers] annotations
    • I verified the change works with dotnet publish -p:PublishAot=true

Testing

  • All existing tests pass (dotnet test)
  • I have added tests that cover my changes
  • I have tested both source-generated and reflection modes (if applicable)

Additional Notes

  • No additional test as IsTruthyEnv existed already

@Crashdummyy

Crashdummyy commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

I verified the change works with dotnet publish -p:PublishAot=true

-p:PublishAot is disabled by design for multi framework projects.
But if it worked before it should still work after

@thomhurst

thomhurst commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Thanks!

@thomhurst
thomhurst merged commit bf3d077 into thomhurst:main Jul 19, 2026
10 of 11 checks passed
@thomhurst thomhurst mentioned this pull request Jul 19, 2026
Merged
1 task
This was referenced Jul 19, 2026
Open
Open
Open
Open
Open
Closed
Merged
Closed
Open
Open
Open
Merged
Open
Closed
Merged
Open
Merged
Merged
Open
Open
Open
This was referenced Jul 20, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Closed
Merged
Merged
github-actions Bot pushed a commit to IntelliTect/CodingGuidelines that referenced this pull request Jul 20, 2026
@dependabot
Bump TUnit.Core from 1.59.0 to 1.61.15 (#479)
49e8263 
Updated [TUnit.Core](https://github.com/thomhurst/TUnit) from 1.59.0 to
1.61.15.

<details>
<summary>Release notes</summary>

_Sourced from [TUnit.Core's
releases](https://github.com/thomhurst/TUnit/releases)._

## 1.61.15

<!-- Release notes generated using configuration in .github/release.yml
at v1.61.15 -->

## What's Changed
### Other Changes
* feat: Allow disabling the automatic html report upload to
upload-artifacts@​v7 by @​Crashdummyy in
thomhurst/TUnit#6447
* fix: stop retrying artifact upload on non-retryable status codes by
@​thomhurst in thomhurst/TUnit#6449
### Dependencies
* chore(deps): update tunit to 1.61.0 by @​thomhurst in
thomhurst/TUnit#6437
* chore(deps): update verify to 31.24.3 by @​thomhurst in
thomhurst/TUnit#6438
* chore(deps): update dependency
opentelemetry.instrumentation.aspnetcore to 1.17.0 by @​thomhurst in
thomhurst/TUnit#6440
* chore(deps): update verify to 31.25.0 by @​thomhurst in
thomhurst/TUnit#6442
* chore(deps): update dependency docusaurus-plugin-llms to ^0.5.0 by
@​thomhurst in thomhurst/TUnit#6443
* chore(deps): update opentelemetry to 1.17.0 by @​thomhurst in
thomhurst/TUnit#6441

## New Contributors
* @​Crashdummyy made their first contribution in
thomhurst/TUnit#6447

**Full Changelog**:
thomhurst/TUnit@v1.61.0...v1.61.15

## 1.61.0

<!-- Release notes generated using configuration in .github/release.yml
at v1.61.0 -->

## What's Changed
### Other Changes
* docs: revamp README with feature showcase and auto-updating benchmarks
by @​thomhurst in thomhurst/TUnit#6430
* docs: align docs homepage messaging with revamped README by
@​thomhurst in thomhurst/TUnit#6431
* fix(engine): emit ECMA-335 metadata-format type names in
TestMethodIdentifierProperty by @​thomhurst in
thomhurst/TUnit#6433
* fix(benchmarks): make SetupTeardownTests JSON tests Native AOT
compatible by @​thomhurst in
thomhurst/TUnit#6434
* Organize repository into conventional .NET layout by @​thomhurst in
thomhurst/TUnit#6435
### Dependencies
* chore(deps): update dependency polyfill to v11 by @​thomhurst in
thomhurst/TUnit#6418
* chore(deps): update dependency tunit.aspire to 1.6* by @​thomhurst in
thomhurst/TUnit#6419
* chore(deps): update tunit to 1.6* by @​thomhurst in
thomhurst/TUnit#6420
* chore(deps): update dependency polyfill to 11.0.1 by @​thomhurst in
thomhurst/TUnit#6421
* chore(deps): update dependency polyfill to 11.0.1 by @​thomhurst in
thomhurst/TUnit#6422
* chore(deps): update verify to 31.24.2 by @​thomhurst in
thomhurst/TUnit#6424
* chore(deps): update microsoft.build to 18.8.2 by @​thomhurst in
thomhurst/TUnit#6426
* chore(deps): update dependency microsoft.net.stringtools to 18.8.2 by
@​thomhurst in thomhurst/TUnit#6425
* chore(deps): update actions/setup-dotnet action to v6 by @​thomhurst
in thomhurst/TUnit#6427
* chore(deps): bump websocket-driver from 0.7.4 to 0.7.5 in /docs by
@​dependabot[bot] in thomhurst/TUnit#6429
* chore(deps): update opentelemetry to 1.17.0 by @​thomhurst in
thomhurst/TUnit#6432


**Full Changelog**:
thomhurst/TUnit@v1.60.0...v1.61.0

## 1.60.0

<!-- Release notes generated using configuration in .github/release.yml
at v1.60.0 -->

## What's Changed
### Other Changes
* feat: cross-process test report aggregation — merged HTML report +
single GitHub summary by @​thomhurst in
thomhurst/TUnit#6415
### Dependencies
* chore(deps): update tunit to 1.59.0 by @​thomhurst in
thomhurst/TUnit#6398
* chore(deps): update verify to 31.24.1 by @​thomhurst in
thomhurst/TUnit#6399
* chore(deps): update microsoft.testing to 2.3.2 by @​thomhurst in
thomhurst/TUnit#6401
* chore(deps): update mstest to 4.3.2 by @​thomhurst in
thomhurst/TUnit#6402
* chore(deps): update actions/setup-node action to v7 by @​thomhurst in
thomhurst/TUnit#6403
* chore(deps): update dependency microsoft.net.test.sdk to 18.8.0 by
@​thomhurst in thomhurst/TUnit#6404
* chore(deps): update dependency microsoft.net.test.sdk to 18.8.1 by
@​thomhurst in thomhurst/TUnit#6405
* chore(deps): update dependency fsharp.core to 10.1.302 by @​thomhurst
in thomhurst/TUnit#6406
* chore(deps): update dependency microsoft.templateengine.authoring.cli
to v10.0.302 by @​thomhurst in
thomhurst/TUnit#6407
* chore(deps): update dependency microsoft.entityframeworkcore to
10.0.10 by @​thomhurst in thomhurst/TUnit#6410
* chore(deps): update dependency dotnet-sdk to v10.0.302 by @​thomhurst
in thomhurst/TUnit#6409
* chore(deps): update dependency system.commandline to 2.0.10 by
@​thomhurst in thomhurst/TUnit#6412
* chore(deps): update dependency
microsoft.templateengine.authoring.templateverifier to 10.0.302 by
@​thomhurst in thomhurst/TUnit#6411
* chore(deps): update microsoft.aspnetcore to 10.0.10 by @​thomhurst in
thomhurst/TUnit#6413
* chore(deps): update microsoft.extensions to 10.0.10 by @​thomhurst in
thomhurst/TUnit#6414
* chore(deps): update microsoft.extensions to 10.8.0 by @​thomhurst in
thomhurst/TUnit#6416
* chore(deps): update dependency polyfill to v11 by @​thomhurst in
thomhurst/TUnit#6417


**Full Changelog**:
thomhurst/TUnit@v1.59.0...v1.60.0

Commits viewable in [compare
view](thomhurst/TUnit@v1.59.0...v1.61.15).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=TUnit.Core&package-manager=nuget&previous-version=1.59.0&new-version=1.61.15)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jul 20, 2026
Merged
Open
Open
Merged
Open
Closed
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomhurst thomhurst thomhurst approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Crashdummyy @thomhurst