Skip to content

Add Finnish translation#131

Merged
thomaspark merged 1 commit intothomaspark:masterfrom
minna-xD:translation-fi
Oct 10, 2020
Merged

Add Finnish translation#131
thomaspark merged 1 commit intothomaspark:masterfrom
minna-xD:translation-fi

Conversation

@minna-xD
Copy link
Copy Markdown
Contributor

@minna-xD minna-xD commented Oct 9, 2020

@thomaspark
Copy link
Copy Markdown
Owner

thomaspark commented Oct 10, 2020

Awesome! Thanks @minna-xD for finnishing the translation so quickly.

@thomaspark thomaspark merged commit cac8680 into thomaspark:master Oct 10, 2020
@minna-xD
Copy link
Copy Markdown
Contributor Author

minna-xD commented Oct 10, 2020

It was fun!
During translation, I noticed some issues with Vietnamese. I don't understand the language at all but the descriptions in docs.js seemed "off" (mentioning integer as a possible value where it wasn't mentioned in English, for example). I can create a more proper issue 😬 later today in case the original translator wants to check. But the vi entries should be reviewed at some point.

@thomaspark
Copy link
Copy Markdown
Owner

thomaspark commented Oct 10, 2020

Oh nice catch, please do open an issue and tag the original translator on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@minna-xD @thomaspark