Pass known categories to the BinMapper #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Wow I'm jealous of this neat CI you have |
Owner
|
It has been pretty useful to have a CI on my fork as well. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Thomas,
This PR passes the known categories from the Hist-GBDT estimator to the BinMapper, instead of letting the BinMapper figure it out.
I think this is preferable when there is some early stopping with a train/val split: we still want the BinMapper to know all the existing categories, not just those that are exclusive to the validation set. This is for the same reason that we allow users to pass a "categories" parameter to e.g. the OneHotEncoder.
One benefit is that we don't need
_find_bin_categoriescategories anymore. There is also no risk of usingbin_mapper.transformon unknown categories now.