Skip to content

Call t.end to finish tests (latest tap compatibility) - #19

Open
kapouer wants to merge 2 commits into
thlorenz:masterfrom
kapouer:tap8
Open

kapouer wants to merge 2 commits into
thlorenz:masterfrom
kapouer:tap8

Conversation

@kapouer

@kapouer kapouer commented Nov 23, 2016

Copy link
Copy Markdown

Fixes #18

@thlorenz thlorenz closed this Nov 25, 2016
@thlorenz

Copy link
Copy Markdown
Owner

Even though not a huge fan, I'll merge this if you update the tap dependency in this package to 8 as well.
I'd love it even more if we'd switch over to tape as I prefer that these days, but that maybe too much work.

@thlorenz thlorenz reopened this Nov 25, 2016
@thlorenz

thlorenz commented Jun 8, 2018

Copy link
Copy Markdown
Owner

Hey, super sorry for this long delay.
I merged your changes, but now am getting errors due to something most likely unrelated.
However I don't have bandwidth to look at it, so maybe you can have a look and we can get this merged?

I made you collaborator. Therefore once we figure out the test failures, please merge to master following this guide.
I will then version and publish to npm.

Thanks.

@kapouer

kapouer commented Jun 8, 2018

Copy link
Copy Markdown
Author

Better later than never ;) I'll have a look.

@legobeat

Copy link
Copy Markdown
Collaborator

Hello @kapouer , some updates:

The original change of calling end for tap-compatibility was done and merged separately in #26.

I have rebased your PR, leaving the tap upgrade. I guess given the time that has passed, this package should support tap versions 12 and 16 to meaningfully solve the original issue (https://packages.debian.org/search?searchon=names&keywords=node-tap).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail with tap version 8.0.0

3 participants