feat: support encryption enforcement configurations#1
Closed
thiyaguk09 wants to merge 4 commits intomainfrom
Closed
feat: support encryption enforcement configurations#1thiyaguk09 wants to merge 4 commits intomainfrom
thiyaguk09 wants to merge 4 commits intomainfrom
Conversation
Adds integration to verify that encryption enforcement configurations are correctly handled during bucket metadata updates. Confirms that `defaultKmsKeyName` is retained during partial updates via server-side strategic merge.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Cloud Storage client library by integrating support for encryption enforcement configurations. It allows users to define and apply policies that restrict the types of encryption used for objects within a bucket, such as enforcing CMEK-only encryption. The changes ensure that these configurations are correctly handled during bucket metadata updates, including partial updates, and are thoroughly tested to guarantee their intended behavior. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for encryption enforcement configurations, including new interfaces, documentation, and tests. The core implementation appears correct. However, I've identified a few issues within the tests. A unit test for setMetadata is flawed because it mocks the method it's supposed to be testing, failing to verify the partial update logic. Additionally, a system test contains a weak and misleading assertion. I've provided detailed feedback and code suggestions to address these points.
pearigee
pushed a commit
that referenced
this pull request
Mar 18, 2026
feat: add package migration scripts
pearigee
pushed a commit
that referenced
this pull request
Mar 18, 2026
* feat: flesh out initial plugin * chore: small cleanup to structure (#2) * chore: release 1.0.0 (#1) * chore: add package-lock.json to .gitignore * fix(license): license to Google (#3) * chore: release 1.0.1 (#4) * fix(deps): remove unused yargs dep (#5) * chore: release 1.0.2 (#6) * fix: node_modules can have folders with .js extension (#3) * chore: fix links to point to googleapis (#7) * chore: release 1.0.3 (#6) * fix: tag issue of undefined (googleapis#11) * chore(deps): update dependency c8 to v7 (googleapis#13) * chore(deps): update dependency mocha to v7 (googleapis#14) * chore: release 1.0.4 (googleapis#12) * chore(deps): update dependency mocha to v8 (googleapis#16) * build: enable standard config (googleapis#19) * chore: add dev deps for cloud rad (googleapis#20) Co-authored-by: Justin Beckwith <[email protected]> * test: stub out system test (googleapis#22) * build: move gittatributes files to node templates (googleapis#21) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/452e1583-6c83-495a-ad97-fb34fc6f653f/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@3a00b7f Source-Link: googleapis/synthtool@d07b7b7 Source-Link: googleapis/synthtool@99c93fe * chore: update comments for using magictoken * chore(node): fix kokoro build path for cloud-rad (googleapis#24) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4bdc1826-2f69-49f1-a63b-94f99cceb5ee/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@89d431f * build: --credential-file-override is no longer required (googleapis#26) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4de22315-84b1-493d-8da2-dfa7688128f5/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@94421c4 * chore: update cloud rad kokoro build job (googleapis#27) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/b742586e-df31-4aac-8092-78288e9ea8e7/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@bd0deaa * build: perform publish using Node 12 (googleapis#28) This PR was generated using Autosynth. 🌈 - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5747555 * chore: start tracking obsolete files (googleapis#29) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7a1b0b96-8ddb-4836-a1a2-d2f73b7e6ffe/targets - [ ] To automatically regenerate this PR, check this box. * fix: move system and samples test from Node 10 to Node 12 (googleapis#30) Source-Author: sofisl <[email protected]> Source-Date: Thu Aug 20 18:29:50 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 05de3e1e14a0b07eab8b474e669164dbd31f81fb Source-Link: googleapis/synthtool@05de3e1 * chore: release 1.0.5 (googleapis#31) * build: track flaky tests for "nightly", add new secrets for tagging (googleapis#32) Source-Author: Benjamin E. Coe <[email protected]> Source-Date: Wed Aug 26 14:28:22 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 8cf6d2834ad14318e64429c3b94f6443ae83daf9 Source-Link: googleapis/synthtool@8cf6d28 Co-authored-by: Benjamin E. Coe <[email protected]> * fix: main was pointing to old location (googleapis#33) * chore: release 1.0.6 (googleapis#34) * build(test): recursively find test files; fail on unsupported dependency versions (googleapis#36) Source-Author: Megan Potter <[email protected]> Source-Date: Fri Sep 11 18:47:00 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: fdd03c161003ab97657cc0218f25c82c89ddf4b6 Source-Link: googleapis/synthtool@fdd03c1 * chore: update bucket for cloud-rad (googleapis#37) Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> Source-Author: F. Hinkelmann <[email protected]> Source-Date: Wed Sep 30 14:13:57 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 079dcce498117f9570cebe6e6cff254b38ba3860 Source-Link: googleapis/synthtool@079dcce * build(node_library): migrate to Trampoline V2 (googleapis#38) Source-Author: Takashi Matsuo <[email protected]> Source-Date: Fri Oct 2 12:13:27 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 0c868d49b8e05bc1f299bc773df9eb4ef9ed96e9 Source-Link: googleapis/synthtool@0c868d4 * chore(deps): update dependency gts to v3 (googleapis#39) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [gts](https://togithub.com/google/gts) | devDependencies | major | [`^2.0.2` -> `^3.0.0`](https://renovatebot.com/diffs/npm/gts/2.0.2/3.0.0) | --- ### Release Notes <details> <summary>google/gts</summary> ### [`v3.0.0`](https://togithub.com/google/gts/blob/master/CHANGELOG.md#​300-httpswwwgithubcomgooglegtscomparev202v300-2020-10-08) [Compare Source](https://togithub.com/google/gts/compare/v2.0.2...v3.0.0) ##### ⚠ BREAKING CHANGES - change default `check` to `lint` ([#​570](https://togithub.com/google/gts/issues/570)) - **deps:** require TypeScript 4.x ([#​565](https://togithub.com/google/gts/issues/565)) ##### Features - Add TypeScript v4 support ([#​551](https://www.github.com/google/gts/issues/551)) ([0883956](https://www.github.com/google/gts/commit/08839565a1d2b4b39d532c9b0b596f01b18856fe)) - change default `check` to `lint` ([#​570](https://www.github.com/google/gts/issues/570)) ([c527b66](https://www.github.com/google/gts/commit/c527b66be1ef6a78ea14b3d29225a8d7fb7097bd)) - generate .eslintignore when running init ([#​521](https://www.github.com/google/gts/issues/521)) ([8bce036](https://www.github.com/google/gts/commit/8bce0368767f0c2ad7d0700deb839962bc928d16)) ##### Bug Fixes - add build/.eslintrc.json to files field ([#​553](https://www.github.com/google/gts/issues/553)) ([3b516ad](https://www.github.com/google/gts/commit/3b516ad5e9f0d58201dde469461db7c6ed1c1b78)) - **deps:** require TypeScript 4.x ([#​565](https://www.github.com/google/gts/issues/565)) ([cbc5267](https://www.github.com/google/gts/commit/cbc5267579ef24e8c8ceaa2ef794df3ef54ea56a)) - **deps:** update dependency update-notifier to v5 ([#​574](https://www.github.com/google/gts/issues/574)) ([9a882bf](https://www.github.com/google/gts/commit/9a882bf4ac30ad06e7b91a65ad5721d8e8b41c4b)) - **deps:** update typescript-eslint monorepo to v2.34.0 ([#​509](https://www.github.com/google/gts/issues/509)) ([998a4ac](https://www.github.com/google/gts/commit/998a4ac9b75c97f04d8e5db37563f32d31652f23)) - **deps:** update typescript-eslint monorepo to v3 (major) ([#​528](https://www.github.com/google/gts/issues/528)) ([e22e173](https://www.github.com/google/gts/commit/e22e17338db2ddb7eb829c821037c2f4e77ff869)) - **deps:** update typescript-eslint monorepo to v4 ([#​556](https://www.github.com/google/gts/issues/556)) ([54148df](https://www.github.com/google/gts/commit/54148dfbd8b5f8b36a0f44f901c5db933393a661)) - better error message for broken tsconfig.json ([#​501](https://www.github.com/google/gts/issues/501)) ([0c17a76](https://www.github.com/google/gts/commit/0c17a76c6650eee1d8abaff11a897a432eeaa65f)) - prohibit calls for it.only and describe.only ([#​499](https://www.github.com/google/gts/issues/499)) ([071c33c](https://www.github.com/google/gts/commit/071c33ceef0e3765166aaebf6ed4698167ac0f98)) ##### [2.0.2](https://www.github.com/google/gts/compare/v2.0.1...v2.0.2) (2020-05-11) ##### Bug Fixes - Revert 'update dependency eslint to v7'" ([#​507](https://www.github.com/google/gts/issues/507)) ([0f9950b](https://www.github.com/google/gts/commit/0f9950b273329dbcce5f3cc20864c3dcd076f08c)) - **deps:** pin release of eslint-typescript ([#​508](https://www.github.com/google/gts/issues/508)) ([bd86b42](https://www.github.com/google/gts/commit/bd86b42e2bb904d3765dee82262e4691a11b9958)) - **deps:** update dependency eslint to v7 ([#​504](https://www.github.com/google/gts/issues/504)) ([6aee159](https://www.github.com/google/gts/commit/6aee1595d0486ae2c7fd68d16b1b59c4c4015753)) ##### [2.0.1](https://www.github.com/google/gts/compare/v2.0.0...v2.0.1) (2020-05-07) ##### Bug Fixes - throw an error if running with an unsupported version of nodejs ([#​493](https://www.github.com/google/gts/issues/493)) ([94fdf1e](https://www.github.com/google/gts/commit/94fdf1eaed634aa73c3e44c7a3d9f1325f773b07)) - **deps:** update dependency meow to v7 ([#​502](https://www.github.com/google/gts/issues/502)) ([cf91cda](https://www.github.com/google/gts/commit/cf91cda1afab25759427511d3c97d0037d61c649)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/jsdoc-region-tag). * build: only check --engine-strict for production deps (googleapis#40) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/75155c02-9dd0-4bb9-8de5-c6ec245fec71/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5451633 * chore: clean up Node.js TOC for cloud-rad (googleapis#41) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/99131b49-d843-4a38-9124-81222e7ab74d/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@901ddd4 Source-Link: googleapis/synthtool@f96d3b4 * docs: updated code of conduct (includes update to actions) (googleapis#45) * chore(docs): update code of conduct of synthtool and templates Source-Author: Christopher Wilcox <[email protected]> Source-Date: Thu Oct 22 14:22:01 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 5f6ef0ec5501d33c4667885b37a7685a30d41a76 Source-Link: googleapis/synthtool@5f6ef0e * build(node): update testing matrix Source-Author: Benjamin E. Coe <[email protected]> Source-Date: Thu Oct 22 22:32:52 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: b7413d38b763827c72c0360f0a3d286c84656eeb Source-Link: googleapis/synthtool@b7413d3 * build(node): don't run prepare during smoke test Source-Author: Benjamin E. Coe <[email protected]> Source-Date: Fri Oct 23 17:27:51 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: a783321fd55f010709294455584a553f4b24b944 Source-Link: googleapis/synthtool@a783321 * build(node): cleanup production deps before installing dev/production Source-Author: Benjamin E. Coe <[email protected]> Source-Date: Mon Oct 26 10:37:03 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 89c849ba5013e45e8fb688b138f33c2ec6083dc5 Source-Link: googleapis/synthtool@89c849b * build(node): add KOKORO_BUILD_ARTIFACTS_SUBDIR to env (googleapis#46) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4517db23-0bde-4f5c-a0d0-6b663836a90c/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@ba9918c * docs: add instructions for authenticating for system tests (googleapis#47) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/305b4f12-f9c7-4cda-8a25-0d5dc36b634b/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@363fe30 * refactor(nodejs): move build cop to flakybot (googleapis#50) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/6beadd04-5b03-401e-9ccb-223912fefc50/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@57c23fa * chore: regenerate common templates (googleapis#52) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2ea6930c-6999-4b7b-87b2-ebae50f55cbb/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.) Source-Link: googleapis/synthtool@c6706ee Source-Link: googleapis/synthtool@b33b0e2 Source-Link: googleapis/synthtool@898b38a * build: add generated-files bot config (googleapis#53) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/29ddb9e6-1ff3-4c74-8153-92d341c7b0a6/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.) Source-Link: googleapis/synthtool@e6f3d54 Source-Link: googleapis/synthtool@04573fd * build: remove codecov action (googleapis#55) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/80be6106-65d5-4cf6-b3c7-c0b786f2ac32/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.) Source-Link: googleapis/synthtool@b891fb4 * feat: add `gcf-owl-bot[bot]` to `ignoreAuthors` (googleapis#56) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/6d4e6343-f274-491c-b4e9-e2dbd090be29/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.) Source-Link: googleapis/synthtool@7332178 * chore: migrate to owl bot (googleapis#58) * chore: migrate to owl bot * chore: copy files from googleapis-gen 397c0bfd367a2427104f988d5329bc117caafd95 * chore: run the post processor * chore: release 1.1.0 (googleapis#63) :robot: I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.0.6...v1.1.0) (2021-06-10) ### Features * add `gcf-owl-bot[bot]` to `ignoreAuthors` ([googleapis#56](https://www.github.com/googleapis/jsdoc-region-tag/issues/56)) ([9e3649a](https://www.github.com/googleapis/jsdoc-region-tag/commit/9e3649a3c1778f65115993048d8eca80e5958df8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore(nodejs): remove api-extractor dependencies (googleapis#66) * feat: replace relative URL with cloud.google.com (googleapis#72) Replace relative URL in description with cloud.google.com * chore: release 1.2.0 (googleapis#73) :robot: I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.1.0...v1.2.0) (2021-07-07) ### Features * replace relative URL with cloud.google.com ([googleapis#72](https://www.github.com/googleapis/jsdoc-region-tag/issues/72)) ([212febc](https://www.github.com/googleapis/jsdoc-region-tag/commit/212febc933c246a5e31675e128ad65c45d300cac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * feat: classdesc can also contain link (googleapis#74) * chore: release 1.3.0 (googleapis#75) :robot: I have created a release \*beep\* \*boop\* --- ## [1.3.0](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.2.0...v1.3.0) (2021-07-08) ### Features * classdesc can also contain link ([googleapis#74](https://www.github.com/googleapis/jsdoc-region-tag/issues/74)) ([e57b3ad](https://www.github.com/googleapis/jsdoc-region-tag/commit/e57b3add05abf0c427c4044d507ca600ef58c102)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * chore: release 1.3.1 (googleapis#80) :robot: I have created a release \*beep\* \*boop\* --- ### [1.3.1](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.3.0...v1.3.1) (2021-08-11) ### Bug Fixes * **build:** migrate to using main branch ([googleapis#79](https://www.github.com/googleapis/jsdoc-region-tag/issues/79)) ([5050615](https://www.github.com/googleapis/jsdoc-region-tag/commit/50506150b7758592df5e389c6a5c3d82b3b20881)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). * build(node): run linkinator against index.html (googleapis#1227) (googleapis#86) * chore(cloud-rad): delete api-extractor config (googleapis#87) * chore: fix the wrong post processor image (googleapis#88) * test: use fake region tag for tests (googleapis#89) * build: add generated samples to .eslintignore (googleapis#90) * build: add srs yaml file (googleapis#1419) (googleapis#103) * build: sdd srs yaml file (googleapis#1419) * build: add sync-repo-settings and change branch protection Source-Link: googleapis/synthtool@ed8079c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:80bfa0c67226453b37b501be7748b2fa2a2676cfeec0012e79e3a1a8f1cbe6a3 * add engines field * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]> * build!: update library to use Node 12 (googleapis#107) * build!: Update library to use Node 12 * chore(main): release 2.0.0 (googleapis#108) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(main): release 2.0.1 (googleapis#112) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore!: upgrade to Node 14 (googleapis#126) * docs: fix node release schedule link Co-authored-by: Jeffrey Rennie <[email protected]> Source-Link: googleapis/synthtool@1a24315 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430 * chore!: upgrade to node 14 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]> * chore(main): release 3.0.0 (googleapis#127) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(nodejs): Add `system-test/fixtures` to `.eslintignore` (googleapis#131) * fix: Add `system-test/fixtures` to `.eslintignore` * refactor: Use `**` Source-Link: googleapis/synthtool@b7858ba Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:abc68a9bbf4fa808b25fa16d3b11141059dc757dbc34f024744bba36c200b40f Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(deps): update dependency c8 to v9 (googleapis#135) * chore: update links in github issue templates (googleapis#141) * chore: update links in github issue templates * chore: update links in github issue templates Source-Link: googleapis/synthtool@38fa49f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:609822e3c09b7a1bd90b99655904609f162cc15acb4704f1edf778284c36f429 * Update owlbot.py * Delete .github/ISSUE_TEMPLATE/bug_report.md * Update bug_report.yml * Delete .github/ISSUE_TEMPLATE/feature_request.md * Update feature_request.yml * Delete .github/ISSUE_TEMPLATE/question.md * Delete .github/scripts/close-invalid-link.cjs * Delete .github/workflows/issues-no-repro.yaml --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <[email protected]> * build: add release-please config, fix owlbot-config * mv from packages to dev-packages * commit package * no samples and system test bc no compile script --------- Co-authored-by: Benjamin Coe <[email protected]> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Lalji Kanjareeya <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Justin Beckwith <[email protected]> Co-authored-by: F. Hinkelmann <[email protected]> Co-authored-by: Yoshi Automation Bot <[email protected]> Co-authored-by: Jeffrey Rennie <[email protected]> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Takashi Matsuo <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]> Co-authored-by: sofisl <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: miguel <[email protected]>
thiyaguk09
pushed a commit
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration to verify that encryption enforcement configurations are correctly handled during bucket metadata updates. Confirms that
defaultKmsKeyNameis retained during partial updates via server-side strategic merge.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕