Fixed issue with invalid CUID when generating v1#11
Merged
thibaultmeyer merged 1 commit intothibaultmeyer:masterfrom Nov 3, 2025
Merged
Fixed issue with invalid CUID when generating v1#11thibaultmeyer merged 1 commit intothibaultmeyer:masterfrom
thibaultmeyer merged 1 commit intothibaultmeyer:masterfrom
Conversation
thibaultmeyer
approved these changes
Nov 3, 2025
thibaultmeyer
pushed a commit
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for the following to return false
CUID.isValid(CUID.randomCUID1().toString())the reason for this is the random number can be a small enough negative number to start the CUID's random bit with a-There is a new test CUIDv1Test#validCreation500000 which highlights the issue, because it's random it may randomly pass, however the 500,000 loops from my testing seems to be enough to get a failure.