Remove make-fetch-happen and replace with native fetch#956
Merged
bdehamer merged 7 commits intotheupdateframework:mainfrom Mar 12, 2026
Merged
Remove make-fetch-happen and replace with native fetch#956bdehamer merged 7 commits intotheupdateframework:mainfrom
bdehamer merged 7 commits intotheupdateframework:mainfrom
Conversation
bdehamer
requested changes
Mar 4, 2026
bdehamer
requested changes
Mar 5, 2026
bdehamer
approved these changes
Mar 11, 2026
ejahnGithub
approved these changes
Mar 12, 2026
Collaborator
ejahnGithub
left a comment
ejahnGithub
left a comment
There was a problem hiding this comment.
Look good to me! Thanks for submitting you first PR to TUF-JS 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces make-fetch-happen with the native fetch. Also updated nock to allow the tests to work with native fetch. This simplifies the codebase and reduces external dependencies.
Native fetch does not have a retry mechanism, so that was removed.
Also, the way timeouts are being handled with native fetch using the AbortSignal class did not work well with nock in the testing, so one test had to be skipped.