Skip to content

Test more keytypes#167

Merged
jku merged 4 commits intotheupdateframework:mainfrom
jku:test-more-keytypes
Aug 21, 2024
Merged

Test more keytypes#167
jku merged 4 commits intotheupdateframework:mainfrom
jku:test-more-keytypes

Conversation

@jku
Copy link
Copy Markdown
Member

@jku jku commented Aug 21, 2024

  • Setup infrastructure for testing different keytypes:
    • repository_simulator.py generates NUM_SIGNERS keys for each of those keytypes (most are not currently needed but I thought better be consistent)
    • Currently only a few keytypes are added: Adding more is not hard but a little more work (since securesystemslib CryptoSigner does not even try to offer every possible key -- we can use cryptography for that)
  • Test the "standard" TUF keys to start with
  • Fix minor issue in --expected-failures
  • Set an expected failure for go-tuf since it does not currently support non-deterministic RSA

jku added 4 commits August 21, 2024 16:37
Now the cached signers have different keytypes.
For now only the keytypes/schemes mentioned in spec are included.

Signed-off-by: Jussi Kukkonen <[email protected]>
These three keytypes are specifically referenced in the spec.

Signed-off-by: Jussi Kukkonen <[email protected]>
Now expected-failures value
* "test_keytype_and_scheme" means all keytype/scheme tests fail
* "test_keytype_and_scheme[rsa/rsassa-pss-sha256]" means that specific
  test fails

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku marked this pull request as ready for review August 21, 2024 15:31
@jku jku requested a review from AdamKorcz August 21, 2024 15:33
@jku jku merged commit 67f38b6 into theupdateframework:main Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants