Remove some unnecessary try-reraise constructions (pylint passing) #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
awwad
force-pushed
the
cleanup_try_reraise
branch
from
ceccd32 to
c22a629
Compare
These changes simplify logic, removing some try/except structures that were unnecessary and potentially confusing, and get us back to passing pylint's test. pylint 2.0.0 adds try-except-raise tests, to catch immediate re-raising after catching an exception, outside of some special cases. See this GitHub comment for more info: #770 (comment) Signed-off-by: Sebastien Awwad <[email protected]>
awwad
force-pushed
the
cleanup_try_reraise
branch
from
c22a629 to
d98152b
Compare
SantiagoTorres
approved these changes
Aug 30, 2018
Member
SantiagoTorres
left a comment
SantiagoTorres
left a comment
There was a problem hiding this comment.
LGTM,
I honestly don't follow why the reraises were there for...
alyptik
reviewed
Aug 30, 2018
alyptik
left a comment
alyptik
left a comment
There was a problem hiding this comment.
Reviewed what I could, but I apologize that I couldn't really dig deeper; I have a hard time reading code effectively on a phone, heh. Will give it a better review once I have a laptop again.
| # Unknown role, re-raise exception. | ||
| except tuf.exceptions.UnknownRoleError: | ||
| raise | ||
| if keyid not in keyids: |
There was a problem hiding this comment.
Maybe I am missing something, but where is UnknownRoleError handled if it's removed here?
| raise | ||
|
|
||
| connection.close() | ||
| return number_of_bytes_received, average_download_speed |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes simplify logic, removing some try/except structures that were unnecessary and potentially confusing, and get us back to passing pylint.
pylint 2.0.0 adds try-except-raise tests, to catch immediate
re-raising after catching an exception, outside of some special
cases. See this GitHub comment for more info:
#770 (comment)
The expectation is that this PR changes no behavior -- just clarity and style.
Fixes issue #: No issue previously listed for this