Skip to content

tests: Add some initial tests for tuf.repository #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jku merged 1 commit into from
Jun 3, 2024
Merged

tests: Add some initial tests for tuf.repository #2651

jku merged 1 commit into from
Jun 3, 2024

Conversation

@jku
Copy link
Member

@jku jku commented May 31, 2024 •
edited
Loading

Hard to tell how easy these are to understand for someone who did not write the module... but here's my attempt at testing the tuf.repository.Repository interface:

  • TestingRepository is an implementation of the interface (mostly a simplified copy of the repository example)
  • that implementation is used in some very simple tests, mostly of do_snapshot and do_timestamp
  • Two tests are marked expectedFailure because of repository: Tweak snapshot/timestamp triggers #2438

@jku jku mentioned this pull request May 31, 2024
Merged
@jku jku force-pushed the add-repository-tests branch from c7699b4 to 3448c3d Compare May 31, 2024 11:18
@jku

This comment was marked as outdated.

Sign in to view
@jku jku force-pushed the add-repository-tests branch from 3448c3d to 3f33e46 Compare June 3, 2024 06:46
@jku jku requested a review from lukpueh June 3, 2024 06:47
@jku jku marked this pull request as ready for review June 3, 2024 06:48
@coveralls
Copy link

coveralls commented Jun 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9345843931

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 96.787%
Totals Coverage Status
Change from base Build 9299080107: -0.8%
Covered Lines: 1541
Relevant Lines: 1578
💛 - Coveralls

@jku

This comment was marked as outdated.

Sign in to view
@jku
tests: Add some initial tests for tuf.repository
2b9cc1e 
These are pretty basic and do not test much about the content of the
repository... but it does check version numbers (and how many versions
have been published) in a couple of situations.

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku force-pushed the add-repository-tests branch from 3f33e46 to 2b9cc1e Compare June 3, 2024 07:12
lukpueh
lukpueh approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think the tests are reasonable and okay easy to understand. The repository is harder and maybe not so intuitive to implement.

@jku jku merged commit bafab1e into theupdateframework:develop Jun 3, 2024
@jku jku deleted the add-repository-tests branch December 30, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukpueh lukpueh lukpueh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jku @coveralls @lukpueh