Allow users to configure custom http.Client or http.RoundTripper in DefaultFetcher#682
Merged
kommendorkapten merged 7 commits intotheupdateframework:masterfrom Apr 16, 2025
Conversation
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
…method Signed-off-by: Meredith Lancaster <[email protected]>
malancas
changed the title
Signed-off-by: Meredith Lancaster <[email protected]>
malancas
changed the title
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
MDr164
approved these changes
Apr 16, 2025
Contributor
|
Thank you for contributing, @malancas 🚀 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #660
This updates the
DefaultFetcherso users can optionally provide a custom http.Client or http.RoundTripper. Note that this removes thetimeoutparameter from theDefaultFetcher#DownloadFilemethod.Once this is merged, I will follow up with another pull request allowing users to configure HTTP request retries in
DownloadFile.