export API to set RefTime of Updater#641
export API to set RefTime of Updater#641kommendorkapten merged 5 commits intotheupdateframework:masterfrom
Conversation
Signed-off-by: Adam Korczynski <[email protected]>
Co-authored-by: Fredrik Skogman <[email protected]> Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
|
Thanks for the contribution @AdamKorcz, would you mind also adding a comment describing this, why it may be useful and any consequences of using this in a real life application? |
Signed-off-by: Adam Korczynski <[email protected]>
faf9792 - LMK if it needs more context. I have kept it short to align the description with other methods in the file. |
Co-authored-by: Fredrik Skogman <[email protected]> Signed-off-by: AdamKorcz <[email protected]>
|
@rdimitrov @trishankatdatadog any thoughts? |
There was a problem hiding this comment.
@rdimitrov @trishankatdatadog any thoughts?
I think it makes sense 👍 I don't think it's worth it that much but I was going to suggest that we can make the RefTime field private and add set/get methods so setting it is even more explicit.
Thanks for these changes, @AdamKorcz 🙌
|
I think it's fine w/out get/set? The other fields are lacking this, and I think it's clear with the current design? |
enabled by theupdateframework/go-tuf#641 Signed-off-by: Adam Korczynski <[email protected]>
3 participants
This PR exports an API to set the
RefTimeof the trusted metadata of anUpdater. This is useful for testing time-related cases in the client outside of go-tufs own repository.