Remove nil error from being printed in "persist metadata" error message#633
Merged
MDr164 merged 1 commit intotheupdateframework:masterfrom May 3, 2024
Merged
Conversation
Signed-off-by: Meredith Lancaster <[email protected]>
MDr164
approved these changes
May 3, 2024
Contributor
MDr164
left a comment
MDr164
left a comment
There was a problem hiding this comment.
I'm currently preparing a really big PR that takes care of error checking in general to avoid things like this from happening but good thing you spotted this one here early.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
==========================================
+ Coverage 70.51% 72.94% +2.43%
==========================================
Files 10 10
Lines 2123 1656 -467
==========================================
- Hits 1497 1208 -289
+ Misses 505 327 -178
Partials 121 121 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When go-tuf is unable to persist the TUF metadata, I receive the error "failed to persist metadata: %!w(<nil>)". Because the code already checks if the error is not nil and returns it if not on line 651, the "failed to persist" error message will always try to print a nil error.