Always use forward slash when splitting target names#612
Merged
rdimitrov merged 1 commit intotheupdateframework:masterfrom Feb 23, 2024
Merged
Always use forward slash when splitting target names#612rdimitrov merged 1 commit intotheupdateframework:masterfrom
rdimitrov merged 1 commit intotheupdateframework:masterfrom
Conversation
Signed-off-by: Fredrik Skogman <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
=======================================
Coverage 70.51% 70.51%
=======================================
Files 10 10
Lines 2123 2123
=======================================
Hits 1497 1497
Misses 505 505
Partials 121 121 ☔ View full report in Codecov by Sentry. |
rdimitrov
approved these changes
Feb 23, 2024
Contributor
rdimitrov
left a comment
rdimitrov
left a comment
There was a problem hiding this comment.
Ah, nice catch! 🚀 I was expecting the issue to be in the library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even when running on Windows, the targets in the root uses forward slash.
Closes #605