Merged
Conversation
client/remote_store.go
Outdated
Contributor
There was a problem hiding this comment.
We can't assume that Content-Length will be present, since the response might be chunked.
Contributor
Author
There was a problem hiding this comment.
Thats why I return -1 below to indicate that fact, or is that logic flawed?
Contributor
There was a problem hiding this comment.
Looks right, must have missed that the first time.
Contributor
|
Are we doing interop tests for both consistent hashing and not? |
Contributor
Author
|
@titanous interop tests for consistent snapshots added |
Signed-off-by: Lewis Marshall <[email protected]>
Signed-off-by: Lewis Marshall <[email protected]>
Signed-off-by: Lewis Marshall <[email protected]>
Signed-off-by: Lewis Marshall <[email protected]>
Signed-off-by: Lewis Marshall <[email protected]>
Signed-off-by: Lewis Marshall <[email protected]>
lmars
force-pushed
the
consistent-snapshots
branch
from
9475c9c to
b0d4c9b
Compare
client/remote_store.go
Outdated
Contributor
|
LGTM pending my last comment. |
Signed-off-by: Lewis Marshall <[email protected]>
rdimitrov
pushed a commit
to rdimitrov/go-tuf
that referenced
this pull request
Jan 25, 2024
…eframework#53) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.11.0 to 0.12.0. - [Commits](golang/crypto@v0.11.0...v0.12.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rdimitrov
pushed a commit
that referenced
this pull request
Jan 29, 2024
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.11.0 to 0.12.0. - [Commits](golang/crypto@v0.11.0...v0.12.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is that repositories will default to using consistent snapshots, and can be disabled by running
tuf init --consistent-snapshot=falsebefore adding any target files.If target files have already been added, the only way to change whether consistent snapshots are used is to run (the yet unimplemented)
tuf regenerate --consistent-snapshot=false.Closes #8.