Support creating and modifying repos by lmars · Pull Request #3 · theupdateframework/go-tuf

lmars · 2014-12-26T04:24:02Z

There are a few TODOs in here which I plan to address, but opening to get feedback on the approach so far.

ping @titanous

titanous · 2014-12-26T16:22:29Z

Ping @heavenlyhash more eyeballs on this would be great.

titanous · 2014-12-26T16:27:56Z

client.go

Let's default to using SHA-512. It's quite a bit faster on x86_64.

Signed-off-by: Lewis Marshall <[email protected]>

lmars · 2014-12-30T02:09:02Z

@titanous @heavenlyhash comments addressed and implementation changed to match proposal #4.

I plan to do the following in smaller PRs once this is merged:

Add a test which checks generated signatures against data generated by the reference implementation
Passphrase protect keys (Passphrase-protect keys #5)
Implement tuf regenerate
Compress manifests when generating snapshot
Implement the client

titanous · 2014-12-30T02:11:19Z

README.md

I don't think this sentence is necessary, anyone interested can follow the link above.

lmars · 2014-12-30T17:56:39Z

@titanous @heavenlyhash comments addressed

titanous · 2014-12-30T18:45:07Z

errors.go

These fields should be exported (in all of them).

Signed-off-by: Lewis Marshall <[email protected]>

lmars · 2014-12-30T19:13:33Z

@titanous comments addressed

titanous · 2014-12-30T19:16:55Z

Looks like the hex encoding isn't working as expected? Probably needs a pointer receiver for the MarshalJSON method or vice versa.

$ cat keys/root-5244d08a4363a884910099276bea11ac62f1dbfa9c6a3d6c5c2f5f723fbfffb4.json
{"id":"5244d08a4363a884910099276bea11ac62f1dbfa9c6a3d6c5c2f5f723fbfffb4","public":[40,139,112,53,148,66,70,72,251,244,113,148,233,138,133,139,86,77,158,187,164,123,82,78,254,29,114,170,133,171,170,48],"private":[237,154,214,248,73,166,191,202,167,146,134,108,198,189,46,231,25,113,252,145,245,87,193,104,197,84,158,10,46,250,163,166,40,139,112,53,148,66,70,72,251,244,113,148,233,138,133,139,86,77,158,187,164,123,82,78,254,29,114,170,133,171,170,48]}

titanous · 2014-12-30T19:17:36Z

Also, all JSON files should be formatted with MarshalIndent and have a trailing newline at the end.

titanous · 2014-12-30T19:18:36Z

This works, which is unexpected:

$ tuf gen-key asdf

titanous · 2014-12-30T19:21:23Z

All expires should be coerced to UTC before saving.

titanous · 2014-12-30T19:29:55Z

One of the initial commands should create the staged/targets directory.

titanous · 2014-12-30T19:33:06Z

tuf snapshot doesn't appear to work:

$ tree .
.
├── keys
│   ├── asdf-949815ba0fa9342dfa1e0489a5fe5a5eda50c073ba3f093cdb52e565f42365f5.json
│   ├── root-5244d08a4363a884910099276bea11ac62f1dbfa9c6a3d6c5c2f5f723fbfffb4.json
│   ├── snapshot-5ca07d17bdab4d06177a2bb8d5f08cb7b438aa4071b52128609b1014df529dc3.json
│   ├── targets-117d877a16096ae667f71d8589c46ca6926b7e16439d49bf23ae7bec4d358039.json
│   └── timestamp-e8e4ff1892f24b700c445bc6ee60955d1797d55e8f2b0eac9c9bc88c745ddad2.json
├── repository
└── staged
    ├── root.json
    ├── targets
    │   └── foo
    └── targets.json

4 directories, 8 files

$ tuf snapshot
tuf: invalid role

Signed-off-by: Lewis Marshall <[email protected]>

lmars · 2014-12-30T22:01:16Z

@titanous comments addressed, just couldn't get the JSON indentation to work for manifests so opened #12

titanous · 2014-12-30T22:15:50Z

errors.go

This should be exported.

Signed-off-by: Lewis Marshall <[email protected]>

titanous · 2014-12-31T00:19:40Z

LGTM

Support creating and modifying repos

Use endophage for client imports

…wman/delegations-in-client Iteration on "Support delegations in client"

…helpers Add version helpers

# This is the 1st commit message: [Delegations prereq] Use a verify.DB for delegation in client Splitting up theupdateframework#175 # This is the commit message theupdateframework#2: stash # This is the commit message theupdateframework#3: Add tests to make sure the top level targets 'delegation' edge has associated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role # This is the commit message theupdateframework#4: [Delegations prereq] Make signers addressible by key ID in LocalStore Splitting up theupdateframework#175 # This is the commit message theupdateframework#5: Clarify naming # This is the commit message theupdateframework#6: Add local_store_test.go # This is the commit message theupdateframework#7: Another test case # This is the commit message theupdateframework#8: [Delegations prereq] Use a verify.DB for delegation in client Splitting up theupdateframework#175

# This is the 1st commit message: [Delegations prereq] Use a verify.DB for delegation in client Splitting up theupdateframework#175 # This is the commit message theupdateframework#2: stash # This is the commit message theupdateframework#3: Add tests to make sure the top level targets 'delegation' edge has associated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role # This is the commit message theupdateframework#4: [Delegations prereq] Make signers addressible by key ID in LocalStore Splitting up theupdateframework#175 # This is the commit message theupdateframework#5: Clarify naming # This is the commit message theupdateframework#6: Add local_store_test.go # This is the commit message theupdateframework#7: Another test case # This is the commit message theupdateframework#8: [Delegations prereq] Use a verify.DB for delegation in client Splitting up theupdateframework#175 # This is the commit message theupdateframework#9: stash # This is the commit message theupdateframework#10: Add tests to make sure the top level targets 'delegation' edge has associated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role

…framework#3) * docs: add comments describing the different types Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: add golangci and codeql Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: begin adding tests Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: add licence notice Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: update licence year to 2023 Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: fix linting error Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: temp limit ci to ubuntu so we don't waste GHA resources Signed-off-by: Radoslav Dimitrov <[email protected]> Signed-off-by: Radoslav Dimitrov <[email protected]>

* docs: add comments describing the different types Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: add golangci and codeql Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: begin adding tests Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: add licence notice Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: update licence year to 2023 Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: fix linting error Signed-off-by: Radoslav Dimitrov <[email protected]> * chore: temp limit ci to ubuntu so we don't waste GHA resources Signed-off-by: Radoslav Dimitrov <[email protected]> Signed-off-by: Radoslav Dimitrov <[email protected]>

titanous reviewed Dec 26, 2014
View reviewed changes

client.go Outdated

Copy link
Copy Markdown

Contributor

titanous Dec 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's default to using SHA-512. It's quite a bit faster on x86_64.

lmars mentioned this pull request Dec 27, 2014

Repository management workflow #4

Closed

lmars force-pushed the persist-repository branch from 2555384 to 67c839b Compare December 29, 2014 20:26

Fix signed tests

d87b331

Signed-off-by: Lewis Marshall <[email protected]>

lmars force-pushed the persist-repository branch from 67c839b to 4134235 Compare December 30, 2014 01:54

titanous reviewed Dec 30, 2014
View reviewed changes

README.md Outdated

Copy link
Copy Markdown

Contributor

titanous Dec 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this sentence is necessary, anyone interested can follow the link above.

lmars force-pushed the persist-repository branch from 4134235 to 51ac540 Compare December 30, 2014 17:54

titanous reviewed Dec 30, 2014
View reviewed changes

errors.go Outdated

Copy link
Copy Markdown

Contributor

titanous Dec 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields should be exported (in all of them).

Support creating and modifying repos

85547ba

Signed-off-by: Lewis Marshall <[email protected]>

lmars force-pushed the persist-repository branch from 51ac540 to a43b1cb Compare December 30, 2014 19:12

lmars added 2 commits December 30, 2014 21:55

Don't allow key generation for invalid roles

28cb5c3

Signed-off-by: Lewis Marshall <[email protected]>

Coerce expiry times to UTC

7343b57

Signed-off-by: Lewis Marshall <[email protected]>

lmars force-pushed the persist-repository branch from 89fa207 to 45855b6 Compare December 30, 2014 22:00

titanous reviewed Dec 30, 2014
View reviewed changes

errors.go Outdated

Copy link
Copy Markdown

Contributor

titanous Dec 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be exported.

lmars added 3 commits December 31, 2014 00:06

Create the staged/targets dir if missing

3b256c7

Signed-off-by: Lewis Marshall <[email protected]>

Fix key JSON serialization

e5dd3f1

Signed-off-by: Lewis Marshall <[email protected]>

Export all error fields

5b9a59e

Signed-off-by: Lewis Marshall <[email protected]>

lmars force-pushed the persist-repository branch from 45855b6 to 5b9a59e Compare December 31, 2014 00:15

lmars added a commit that referenced this pull request Dec 31, 2014

Merge pull request #3 from flynn/persist-repository

89be826

Support creating and modifying repos

lmars merged commit 89be826 into master Dec 31, 2014

lmars deleted the persist-repository branch December 31, 2014 00:24

titanous pushed a commit that referenced this pull request Jun 22, 2015

Merge pull request #3 from dmcgowan/stores-imports

ce50da4

Use endophage for client imports

ethan-lowman-dd pushed a commit to ethan-lowman-dd/go-tuf that referenced this pull request Jul 14, 2021

Merge pull request theupdateframework#3 from ethan-lowman-dd/ethan.lo…

22b1e63

…wman/delegations-in-client Iteration on "Support delegations in client"

lebauce pushed a commit to lebauce/go-tuf that referenced this pull request Jul 26, 2021

Merge pull request theupdateframework#3 from DataDog/raphael/version_…

f621e85

…helpers Add version helpers

Conversation

lmars commented Dec 26, 2014

Uh oh!

titanous commented Dec 26, 2014

Uh oh!

titanous Dec 26, 2014

Choose a reason for hiding this comment

Uh oh!

lmars commented Dec 30, 2014

Uh oh!

titanous Dec 30, 2014

Choose a reason for hiding this comment

Uh oh!

lmars commented Dec 30, 2014

Uh oh!

titanous Dec 30, 2014

Choose a reason for hiding this comment

Uh oh!

lmars commented Dec 30, 2014

Uh oh!

titanous commented Dec 30, 2014

Uh oh!

titanous commented Dec 30, 2014

Uh oh!

titanous commented Dec 30, 2014

Uh oh!

titanous commented Dec 30, 2014

Uh oh!

titanous commented Dec 30, 2014

Uh oh!

titanous commented Dec 30, 2014

Uh oh!

lmars commented Dec 30, 2014

Uh oh!

titanous Dec 30, 2014

Choose a reason for hiding this comment

Uh oh!

titanous commented Dec 31, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants