Support modifying role thresholds#135
Merged
trishankatdatadog merged 4 commits intotheupdateframework:masterfrom Jun 30, 2021
Merged
Support modifying role thresholds#135trishankatdatadog merged 4 commits intotheupdateframework:masterfrom
trishankatdatadog merged 4 commits intotheupdateframework:masterfrom
Conversation
Signed-off-by: Asra Ali <[email protected]>
mnm678
reviewed
Jun 24, 2021
Collaborator
mnm678
left a comment
mnm678
left a comment
There was a problem hiding this comment.
My go skills are a bit rusty (no pun intended), but this looks good to me. There's a couple of bits that would need to change for delegations, but I don't think that's a blocker.
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
trishankatdatadog
approved these changes
Jun 30, 2021
Contributor
trishankatdatadog
left a comment
trishankatdatadog
left a comment
There was a problem hiding this comment.
Very nice functionality, thanks! Clearly the code will need to change when we add delegations, but this is very much needed.
Contributor
|
I am happy with merging. Marina? |
mnm678
approved these changes
Jun 30, 2021
Collaborator
LGTM, but I'm not a maintainer |
Pull Request Test Coverage Report for Build 978833412
💛 - Coveralls |
mnm678
pushed a commit
to mnm678/go-tuf
that referenced
this pull request
Oct 21, 2021
* Support modifying role thresholds Signed-off-by: Asra Ali <[email protected]> * add getter Signed-off-by: Asra Ali <[email protected]> * error condition when delegation Signed-off-by: Asra Ali <[email protected]> * fix valid manifest Signed-off-by: Asra Ali <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to modify role thresholds in the CLI
Fixes #6
Question: are there CLI tests?
Signed-off-by: Asra Ali [email protected]