Fix to enable loading from current directory #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
There should probably be a test added that fails with current master but is fixed by this change. |
Contributor
Author
|
@RazerM You're right, I added such a test. |
Contributor
Author
|
Oops I'm sorry, I made a mistake, I'm investigating it. |
|
This is an important correction. It would be nice to have this merged back in. |
Contributor
Author
|
@pvmm I thought so too, as the issue it fixes has been reported at least twice, but this PR has received zero attention from the maintainers since I opened it almost two months ago. |
|
Bumping this issue as its pretty important |
Owner
|
❤️ Merged in! Thanks everyone! |
johnbergvall
pushed a commit
to johnbergvall/python-dotenv
that referenced
this pull request
Aug 13, 2021
* Fix to enable loading from current directory * Add test to make sure loading from current dir works * Reorder test_core tests to avoid directory problem * Reorder curr dir test again, and use os.chdir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #108, which is due I believe to the fact that
find_dotenvdoes not go back far enough in the call stack to find the calling module, which causes its path searching starting point to be itself (i.e.main.py).@theskumar, @RazerM