Use cover method from Intervention
#419
Conversation
deluxetom
changed the title
cover method from Intervention
deluxetom
changed the title
cover method from Interventioncover method from Intervention
deluxetom
changed the title
cover method from Interventioncover method from Intervention
|
@ADmad I've been using this update with a project already, the documentation for |
Sounds good to me, would you like to take care of that? |
I think I can get started on the |
|
Docs for |
my bad, I was looking at the |
|
@ADmad this is ready for review |
docs/3.0/api/crop.md
Outdated
|
|
||
| ~~~ html | ||
| <img src="kayaks.jpg?w=300&h=300&fit=crop-25-75"> | ||
| <img src="kayaks.jpg?w=300&h=300&fit=cover-25-75"> |
There was a problem hiding this comment.
Shouldn't this be crop-25-75. For numeric values for position we use runCropReize() right?
| - `fill`: Resizes the image to fit within the width and height boundaries without cropping or distorting the image, and the remaining space is filled with the background color. The resulting image will match the constraining dimensions. | ||
| - `fill-max`: Resizes the image to fit within the width and height boundaries without cropping but upscaling the image if it's smaller. The finished image will have remaining space on either width or height (except if the aspect ratio of the new image is the same as the old image). The remaining space will be filled with the background color. The resulting image will match the constraining dimensions. | ||
| - `stretch`: Stretches the image to fit the constraining dimensions exactly. The resulting image will fill the dimensions, and will not maintain the aspect ratio of the input image. | ||
| - `crop`: Resizes the image to fill the width and height boundaries and crops any excess image data. The resulting image will match the width and height constraints without distorting the image. See the [crop](api/crop/) page for more information. |
There was a problem hiding this comment.
I think we should keep the crop option stating it's an alias for cover.
|
Just to confirm using
|
that's correct, |
|
@deluxetom Can you please address the couple of comments I had left for the docs page updates. |
|
@ADmad updated! |
2 participants
fit=cropshould use the resizecovermethod from Intervention #420Intervention v3 has a
covermethod that works as intended for thefit=cropparameter.https://image.intervention.io/v3/modifying/resizing#cropping--resizing-combined