Fix interlacing #387
Fix interlacing #387
Conversation
Interlacing for all png was added by @konnng-dev in Art4#1 |
ADmad
force-pushed
the
3.x-interlacing
branch
from
ad5a309 to
c93082e
Compare
Hmm.. I am leaning towards reverting it and maintaining status quo. |
|
Oh, it was indeed my fault I can submit a new PR just interlacing JPEGS. But I would like to have option to interlace pngs on demand as well. |
Interlacing for JPGs only seems to be working when using Imagick. So need to look into that later or state that as a limitation in the docs.
ADmad
force-pushed
the
3.x-interlacing
branch
from
c93082e to
10c8b36
Compare
You can open a separate PR for that. |
|
Gonna merge this. Will look into JPG interlacing not working with Gd later or just state that as a limitation if me or someone else can't sort it out. |
|
@ADmad I can confirm that interlaced JPEG doesn't work w/ GD Looking deep, it seems it is caused by intervention GD Driver JpegEncoder. It seems the encoder clones the image instance, losing the intervention flag set. |
@konnng-dev I took your changes from Art4#2 to fix interlacing.
Though when testing the generated image, interlacing doesn't seem to work for JPEGs when using GD.
With Imagick
identify -verbose kayak.jpeg | grep InterlacegivesInterlace: JPEGbut with GD it givesInterlace: None.It seems to work fine for PNGs for either driver.
@Art4 BTW Glide v2 doesn't interlace PNGs but you have added interlacing for all PNGs in v3. Is that intentional?