Skip to content

Conversation

@pxlrbt
Copy link
Contributor

@pxlrbt pxlrbt commented Dec 1, 2023

Hey,

I know that the example code doesn't show any usage combined with signed routes (maybe that's worth an example, too?), but since it's not a big change, I think it might make sense to remove the signature params from the request in the example.

I used that code, made the route signed later on and DoS my server with cache images 😅 Just want to prevent others from making the same mistake.

Cheers,
Dennis

@ADmad ADmad merged commit c5f76fe into thephpleague:master Dec 1, 2023
@pxlrbt pxlrbt deleted the patch-2 branch December 1, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants