Refine player seek bar, equalizer controls, and duration reconciliation#994
Merged
theovilardo merged 1 commit intomasterfrom Feb 5, 2026
Merged
Refine player seek bar, equalizer controls, and duration reconciliation#994theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
- **Duration & Playback Logic**:
- Introduces `resolveEffectiveDuration` in `PlaybackStateHolder` to reconcile player-reported duration with song metadata, preventing progress UI jumps during track transitions or remote sessions.
- Implements a mismatch tolerance (1500ms) to prefer metadata hints unless the current position exceeds them.
- Adds media ID validation in local progress updates to prevent UI updates for the wrong track during engine swaps.
- **Equalizer & Audio Controls**:
- Refactors `EqualizerViewModel` to update UI state immediately for better responsiveness while debouncing persistence to `userPreferencesRepository`.
- Implements proper state management for Bass Boost, Virtualizer, and Loudness Enhancer with value clamping and debounced storage.
- Updates `VerticalStarSlider` and `WavyArcSlider` with improved gesture handling that correctly disallows parent touch interception during interaction.
- **Player UI & Components**:
- Replaces manual gesture detection in `WavySliderExpressive` with a standard `Slider` overlay to handle interactions, while maintaining the `LinearWavyProgressIndicator` for visualization.
- Adjusts `PlayerSeekBar` and `FullPlayerContent` padding to align progress tracks with the screen edges.
- Updates `FullPlayerContent` to use the new duration reconciliation logic for displaying time labels and calculating progress fractions.
- **Visual Refinements**:
- Smooths the "Pill Morph" animation for the seek bar thumb during user interaction.
- Ensures consistent track coloring and rotation logic for equalizer sliders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveEffectiveDurationinPlaybackStateHolderto reconcile player-reported duration with song metadata, preventing progress UI jumps during track transitions or remote sessions.EqualizerViewModelto update UI state immediately for better responsiveness while debouncing persistence touserPreferencesRepository.VerticalStarSliderandWavyArcSliderwith improved gesture handling that correctly disallows parent touch interception during interaction.WavySliderExpressivewith a standardSlideroverlay to handle interactions, while maintaining theLinearWavyProgressIndicatorfor visualization.PlayerSeekBarandFullPlayerContentpadding to align progress tracks with the screen edges.FullPlayerContentto use the new duration reconciliation logic for displaying time labels and calculating progress fractions.