Merged
Conversation
- **Lyrics Management**:
- Adds a confirmation dialog to `LyricsMoreBottomSheet` when resetting imported lyrics to prevent accidental deletions.
- Improves `PlayerViewModel` lyrics update logic to safely handle empty song metadata during resets, ensuring current song details are preserved while lyrics are cleared.
- **UI & UX**:
- **Album Detail Screen**: Integrates an `ExpressiveScrollBar` that appears during scrolling and adjusts the Floating Action Button (FAB) padding dynamically based on mini-player visibility.
- **Album Detail Screen**: Optimizes list layout by hiding album art in song items (since it's already in the header) and increasing the high-resolution target size for the header art to 1600x1600.
- **Player & Data Safety**:
- Modifies `PlayerViewModel` to block the deletion of the currently playing song from the device, replacing the previous logic that attempted to stop playback mid-deletion.
- Updates `LyricsMoreBottomSheet` to utilize `mutableStateOf` for local UI state management.
…brary sorting interface.
- **Data & Preferences**:
- Adds `IS_ALBUMS_LIST_VIEW` to `UserPreferencesRepository` to persist the user's preferred layout for the albums tab.
- Updates `PlayerUiState` and `PlayerViewModel` to track and expose the album view mode.
- **Library Screen**:
- Implements `AlbumListItem`, a new list-based layout for albums featuring dynamic color schemes, smart image loading, and genre-inspired typography.
- Updates `LibraryAlbumsTab` to conditionally render either a `LazyVerticalGrid` or `LazyColumn` based on the user's preference.
- Integrates prefetching logic and scrollbar support for the new album list view.
- **UI Components**:
- Extends `LibrarySortBottomSheet` to support custom view toggle content.
- Introduces a new `ToggleSegmentButton` variant that includes both icons and text for better visual clarity.
- Refines `LyricsMoreBottomSheet` by cleaning up unused color parameters in the favorite/shuffle toggle row.
- **Miscellaneous**:
- Standardizes `ExpressiveScrollBar` imports across the library screens.
…ved UI/UX and better content organization.
- **SongInfoBottomSheet**:
- Implements a `HorizontalPager` to separate song actions and metadata into "Options" and "Info" tabs.
- Adds a custom bottom `TabRow` with `TabAnimation` for navigating between the pager views.
- Integrates `animateContentSize` to smoothly handle height transitions between different pages.
- Refines the layout of action buttons (Play, Favorite, Share, Queue, Playlist, Delete) into a more compact, grid-like arrangement within the "Options" tab.
- Replaces the `verticalScroll` with `LazyColumn` for more efficient list rendering of song details.
- **LibrarySortBottomSheet**:
- Redesigns the sort option items with a more cohesive grouped appearance using `RoundedCornerShape`.
- Adjusts vertical spacing and padding for a cleaner, more modern look.
- Updates selection styling to use subtle rounded containers instead of pill-shaped `Surface` components.
- **TabAnimation**:
- Introduces a `transformOrigin` parameter to allow customizable scaling anchors during tab transitions.
- Reduces the active scale factor from `1.15f` to `1.05f` for a more subtle selection effect.
- Refines internal padding and layout to support the new bottom tab bar design.
…ved UI/UX and better content organization.
- **SongInfoBottomSheet**:
- Implements a `HorizontalPager` to separate song actions and metadata into "Options" and "Info" tabs.
- Adds a custom bottom `TabRow` with `TabAnimation` for navigating between the pager views.
- Integrates `animateContentSize` to smoothly handle height transitions between different pages.
- Refines the layout of action buttons (Play, Favorite, Share, Queue, Playlist, Delete) into a more compact, grid-like arrangement within the "Options" tab.
- Replaces the `verticalScroll` with `LazyColumn` for more efficient list rendering of song details.
- **LibrarySortBottomSheet**:
- Redesigns the sort option items with a more cohesive grouped appearance using `RoundedCornerShape`.
- Adjusts vertical spacing and padding for a cleaner, more modern look.
- Updates selection styling to use subtle rounded containers instead of pill-shaped `Surface` components.
- **TabAnimation**:
- Introduces a `transformOrigin` parameter to allow customizable scaling anchors during tab transitions.
- Reduces the active scale factor from `1.15f` to `1.05f` for a more subtle selection effect.
- Refines internal padding and layout to support the new bottom tab bar design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.