Integrate artist image fetching and refine UI component styling#946
Merged
theovilardo merged 1 commit intomasterfrom Jan 29, 2026
Merged
Integrate artist image fetching and refine UI component styling#946theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
- **Artist Data & Metadata**:
- Integrates `ArtistImageRepository` into `MusicRepositoryImpl` to support artist image retrieval.
- Enhances `getArtists` to combine MediaStore song data with cached database artists, enabling the display of remote artist images.
- Implements an asynchronous prefetch mechanism in `MusicRepositoryImpl` to fetch missing artist images without blocking the UI.
- Updates `ArtistImageRepository` with a `failedFetches` cache to prevent redundant API calls for non-existent artist images and improved error handling for timeouts.
- **Theming & UI**:
- Adds a `contrastColor` utility to `GenreColors.kt` to dynamically determine the best text color (black/white) based on background luminance, improving accessibility across dynamic genre themes.
- Updates `GenreDetailScreen` to use the standard `Rounded.Menu` icon for options and cleans up `LocalContentColor` imports.
- Refines the vector path and attributes for `rounded_menu_24.xml` for better visual consistency.
- Adds `rounded_bottom_drawer_24.xml` vector resource.
- **Dependency Injection**:
- Updates `AppModule` to provide `ArtistImageRepository` to `MusicRepositoryImpl`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Artist Data & Metadata:
ArtistImageRepositoryintoMusicRepositoryImplto support artist image retrieval.getArtiststo combine MediaStore song data with cached database artists, enabling the display of remote artist images.MusicRepositoryImplto fetch missing artist images without blocking the UI.ArtistImageRepositorywith afailedFetchescache to prevent redundant API calls for non-existent artist images and improved error handling for timeouts.Theming & UI:
contrastColorutility toGenreColors.ktto dynamically determine the best text color (black/white) based on background luminance, improving accessibility across dynamic genre themes.GenreDetailScreento use the standardRounded.Menuicon for options and cleans upLocalContentColorimports.rounded_menu_24.xmlfor better visual consistency.rounded_bottom_drawer_24.xmlvector resource.Dependency Injection:
AppModuleto provideArtistImageRepositorytoMusicRepositoryImpl.