Skip to content

Integrate artist image fetching and refine UI component styling#946

Merged
theovilardo merged 1 commit intomasterfrom
impl/genre-screen-redesign
Jan 29, 2026
Merged

Integrate artist image fetching and refine UI component styling#946
theovilardo merged 1 commit intomasterfrom
impl/genre-screen-redesign

Conversation

@theovilardo
Copy link
Copy Markdown
Owner

  • Artist Data & Metadata:

    • Integrates ArtistImageRepository into MusicRepositoryImpl to support artist image retrieval.
    • Enhances getArtists to combine MediaStore song data with cached database artists, enabling the display of remote artist images.
    • Implements an asynchronous prefetch mechanism in MusicRepositoryImpl to fetch missing artist images without blocking the UI.
    • Updates ArtistImageRepository with a failedFetches cache to prevent redundant API calls for non-existent artist images and improved error handling for timeouts.
  • Theming & UI:

    • Adds a contrastColor utility to GenreColors.kt to dynamically determine the best text color (black/white) based on background luminance, improving accessibility across dynamic genre themes.
    • Updates GenreDetailScreen to use the standard Rounded.Menu icon for options and cleans up LocalContentColor imports.
    • Refines the vector path and attributes for rounded_menu_24.xml for better visual consistency.
    • Adds rounded_bottom_drawer_24.xml vector resource.
  • Dependency Injection:

    • Updates AppModule to provide ArtistImageRepository to MusicRepositoryImpl.

- **Artist Data & Metadata**:
    - Integrates `ArtistImageRepository` into `MusicRepositoryImpl` to support artist image retrieval.
    - Enhances `getArtists` to combine MediaStore song data with cached database artists, enabling the display of remote artist images.
    - Implements an asynchronous prefetch mechanism in `MusicRepositoryImpl` to fetch missing artist images without blocking the UI.
    - Updates `ArtistImageRepository` with a `failedFetches` cache to prevent redundant API calls for non-existent artist images and improved error handling for timeouts.

- **Theming & UI**:
    - Adds a `contrastColor` utility to `GenreColors.kt` to dynamically determine the best text color (black/white) based on background luminance, improving accessibility across dynamic genre themes.
    - Updates `GenreDetailScreen` to use the standard `Rounded.Menu` icon for options and cleans up `LocalContentColor` imports.
    - Refines the vector path and attributes for `rounded_menu_24.xml` for better visual consistency.
    - Adds `rounded_bottom_drawer_24.xml` vector resource.

- **Dependency Injection**:
    - Updates `AppModule` to provide `ArtistImageRepository` to `MusicRepositoryImpl`.
@theovilardo theovilardo merged commit d3d3b7d into master Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant