Fix: Ensure up-to-date metadata is used after editing#748
Merged
theovilardo merged 1 commit intomasterfrom Jan 6, 2026
Merged
Conversation
Ensures that when a song is played or its metadata is edited, the most current version of the song's information is used, preventing stale data from being displayed or used. - In `PlayerViewModel`, the `showAndPlaySong` function now retrieves the latest version of the song from the `allSongs` list. This ensures any recent metadata changes are immediately reflected when the song is played. - Skips direct file modification for `.opus` and `.ogg` files during metadata editing to prevent file corruption issues caused by tagging libraries. The app will now only update the MediaStore and its local database for these formats, which is sufficient for the changes to be reflected within the app. - Refactors the metadata editing logic in `SongMetadataEditor` to use the file path directly instead of the song ID for media rescans and file operations, making the process more reliable. - Adds extensive logging to the metadata editing process for improved debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that when a song is played or its metadata is edited, the most current version of the song's information is used, preventing stale data from being displayed or used.
PlayerViewModel, theshowAndPlaySongfunction now retrieves the latest version of the song from theallSongslist. This ensures any recent metadata changes are immediately reflected when the song is played..opusand.oggfiles during metadata editing to prevent file corruption issues caused by tagging libraries. The app will now only update the MediaStore and its local database for these formats, which is sufficient for the changes to be reflected within the app.SongMetadataEditorto use the file path directly instead of the song ID for media rescans and file operations, making the process more reliable.