Refactor: Improve Baseline Profile generation and recovery#651
Merged
theovilardo merged 1 commit intoperf/baseline-prof-integrationfrom Dec 26, 2025
Conversation
Improves the reliability and clarity of the `BaselineProfileGenerator` script. - **Profile Recovery:** - Standardizes the output path for the generated profile to `/sdcard/Android/media/com.theveloper.pixelplay.baselineprofile/baseline-prof.txt`, ensuring consistent write permissions. - Adds logging and a 5-second delay after the `killall` command to allow more time for the profile to be written to disk before copying. - **Generator Script:** - Cleans up the script by removing redundant comments and unnecessary `Log.w` calls for non-critical path failures (e.g., if the "Stats" element isn't found). - Simplifies comments in the player UI and queue interaction steps for better readability. - Adds a title to the "Home Screen Extended Flow" section to clarify that it covers "Daily Mix & Stats".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
lostf1sh
deleted the
update-baseline-profile-generator-8173872469908419694
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the reliability and clarity of the
BaselineProfileGeneratorscript.Profile Recovery:
/sdcard/Android/media/com.theveloper.pixelplay.baselineprofile/baseline-prof.txt, ensuring consistent write permissions.killallcommand to allow more time for the profile to be written to disk before copying.Generator Script:
Log.wcalls for non-critical path failures (e.g., if the "Stats" element isn't found).