Improve baseline profile generation flow#635
Merged
theovilardo merged 4 commits intoperf/baseline-prof-integrationfrom Dec 25, 2025
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Introduces a `is_benchmark` intent flag to streamline app startup during Baseline Profile generation, bypassing setup screens and permission dialogs for a more stable and direct launch to the main screen. - **MainActivity.kt**: - Reads a new `is_benchmark` boolean extra from the intent. - Skips the `SetupScreen` if `is_benchmark` is true. - Prevents the "All Files Access" dialog from appearing during benchmark runs. - **BaselineProfileGenerator.kt**: - Simplifies the generation script to perform only a cold start and a brief wait, removing complex UI interactions (tab navigation, scrolling, sheet opening) that caused instability. - Launches the app with the `--ez is_benchmark true` flag to ensure a direct path to the `HomeScreen`. - Grants `MANAGE_EXTERNAL_STORAGE` and `POST_NOTIFICATIONS` permissions via shell commands before the run to avoid system dialogs. - **HomeScreen.kt**: - Adds `ReportDrawnWhen` to signal when the screen is fully drawn, using the presence of songs or the `is_benchmark` flag as a trigger. - Suppresses the app rebrand dialog when in benchmark mode. - **Build & Dependencies**: - Adds a new `benchmark` build type in `app/build.gradle.kts` that inherits from `release` but is debuggable. - Updates `benchmark-macro-junit4` and `baselineprofile` libraries to version `1.3.3`. - Includes the `baselineprofile` module in the Gradle project settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task