Skip to content

Fix lyrics sheet cancellation and LRC timestamp parsing#606

Merged
theovilardo merged 4 commits intomasterfrom
codex/fix-lyricssheet-behavior-and-timestamp-parsing
Dec 22, 2025
Merged

Fix lyrics sheet cancellation and LRC timestamp parsing#606
theovilardo merged 4 commits intomasterfrom
codex/fix-lyricssheet-behavior-and-timestamp-parsing

Conversation

@theovilardo
Copy link
Copy Markdown
Owner

Summary

  • Close the lyrics sheet when the fetch/import dialog is dismissed without loading lyrics for the current song
  • Strip LRC timestamp tags (including multiple per line) from parsed lyrics and displayed lines
  • Add unit coverage for LRC timestamp removal and lyric text sanitization

Testing

  • ./gradlew :app:testDebugUnitTest --tests com.theveloper.pixelplay.utils.LyricsUtilsTest --tests com.theveloper.pixelplay.presentation.components.LyricsSheetLogicTest (fails: SDK location not configured in environment)

Codex Task

This commit introduces several stylistic improvements to the `FetchLyricsDialog` component.

- Replaces the main decorative icon's background from a `RoundedCornerShape` to a `RoundedStarShape` with 8 sides.
- Changes the "Import from .lrc file" button from `OutlinedButton` to a filled `Button` using secondary theme colors for better emphasis.
- Reduces the size of the main decorative icon from `80.dp` to `72.dp`.
@theovilardo theovilardo merged commit 20936ad into master Dec 22, 2025
@lostf1sh lostf1sh deleted the codex/fix-lyricssheet-behavior-and-timestamp-parsing branch January 16, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant