Unify player bottom sheet dimming and scaling#595
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| when { | ||
| queueOpenFraction > 0f -> animateQueueSheet(false) | ||
| castSheetOpenFraction > 0f -> showCastSheet = false | ||
| currentSheetContentState == PlayerSheetState.EXPANDED -> { |
There was a problem hiding this comment.
Tapping the dim overlay while the cast sheet is open only flips showCastSheet to false but never clears castSheetOpenFraction. Because the overlay visibility now depends on bottomSheetOpenFraction = max(queueOpenFraction, castSheetOpenFraction), that stale fraction stays >0 after the cast sheet composable is removed. The dim layer therefore remains visible and intercepts all touches even though no sheet is shown, effectively leaving the UI stuck until some other state change resets the fraction. Consider zeroing castSheetOpenFraction (or invoking the dismiss handler) when dismissing via the scrim.
Useful? React with 👍 / 👎.
Adds the `zIndex` modifier import to `UnifiedPlayerSheet.kt`. This is a preparatory step for upcoming layout adjustments.
1 participant
Summary
Testing
Codex Task