Fix Light Mode Player UI Contrast & Backgrounds#535
Conversation
Corrects the Light Mode dynamic color generation in `ColorRoles.kt` to align with Material 3 standards. - Changes `lightPrimary` to Tone 40 (was 64), ensuring `onPrimary` is White. This fixes black button backgrounds. - Changes `primaryContainer` to Tone 90 (was 92) and `onPrimaryContainer` to Tone 10 (was 56) for better text contrast. - Updates `background` and `surface` to Tone 99 for a cleaner light theme. - Dark Mode logic is completely preserved.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
…e 95 - Defines `lightPrimary95`, `lightSecondary95`, and `lightTertiary95` derived from the album art seed. - Updates `lightScheme` to use these tinted tones for `onPrimary`, `onSecondary`, and `onTertiary` instead of `Color.White`. - This ensures button backgrounds in the player UI are not 100% white but have a subtle, expressive tint matching the album art, improving visual cohesion in Light Mode while maintaining accessibility. - Dark Mode remains untouched.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
This PR addresses the user-reported issues with the Light Mode Player UI where backgrounds were rendering black and text contrast was poor.
Changes:
generateColorSchemeFromSeedinColorRoles.kt:lightSchemegeneration logic to use standard Material 3 tonal values.primaryto Tone 40 andonPrimaryto White (fixing the "Black Button" issue).primaryContainerto Tone 90 andonPrimaryContainerto Tone 10 (fixing text legibility on the player card).backgroundandsurfaceto Tone 99 (fixing muddy backgrounds).lightPrimary40,lightPrimary10).Verification:
darkSchemeblock remains untouched to preserve the working Dark Mode.PR created automatically by Jules for task 6341497516053891833 started by @theovilardo