Skip to content

Add hierarchical file explorer for directory selection#487

Merged
theovilardo merged 12 commits intomasterfrom
codex/implementar-file-explorer-jerarquico-en-pixelplay
Dec 10, 2025
Merged

Add hierarchical file explorer for directory selection#487
theovilardo merged 12 commits intomasterfrom
codex/implementar-file-explorer-jerarquico-en-pixelplay

Conversation

@theovilardo
Copy link
Copy Markdown
Owner

Summary

  • add a reusable file explorer state holder to navigate storage and toggle allowed music directories
  • replace setup and settings folder pickers with a hierarchical Material 3 bottom sheet
  • gate the explorer behind existing storage permission checks

Testing

  • not run (not requested)

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +63 to +67
val parentCanonical = runCatching { parent.canonicalPath }.getOrNull()
val isAboveRoot = parentCanonical?.startsWith(rootCanonicalPath) == false

if (isAboveRoot || current.path == visibleRoot.path) {
loadDirectory(visibleRoot)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Explorer cannot reach SD card directories

Navigation is clamped to the visibleRoot (set to Environment.getExternalStorageDirectory()), and navigateUp snaps back to that root whenever the parent is outside it. Because the explorer always starts at /storage/emulated/0 and cannot ascend to /storage, users on devices with removable storage cannot browse or re-allow music folders on secondary volumes like /storage/XXXX-XXXX, a capability the previous MediaStore-backed picker provided.

Useful? React with 👍 / 👎.

@theovilardo theovilardo merged commit d973510 into master Dec 10, 2025
@lostf1sh lostf1sh deleted the codex/implementar-file-explorer-jerarquico-en-pixelplay branch January 16, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant